Repository navigation
fix: keep the SSH login signal off hosts without an SSH terminal - #66
Merged
LukeGus merged 2 commits intoNov 16, 2026
Merged
Conversation
The SSH login signal reads ssh-terminal.check-login on every host the user can reach, every ten minutes. Its actions had no when rule, so core ran them on RDP-only hosts too, and the dashboard and host page showed an SSH login error for a host that has SSH turned off. The host actions now apply only where enableTerminal is on. Core already skips a host whose settings do not match an action's when rule. Hosts that never set it read the default, which is on. Fixes Termix-SSH/Termix#1795
|
AI review | Looks safe to merge The PR adds a when condition to three host-scoped actions in manifest.json to skip SSH terminal checks on hosts where the feature is disabled, and includes a test to verify the behavior. The change is safe, follows plugin standards, and correctly resolves the reported issue. Reviewed af615e1. AI can be wrong, a maintainer still decides. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Termix-SSH/Termix#1795 (also reported as #1800 there).
An RDP-only host, saved with SSH and status checks off, shows
SSH Login: read ECONNRESETon the dashboard and the new host page right away.That comes from this plugin's
ssh-terminal.loginsignal. It readsssh-terminal.check-loginper host every 600 seconds. The host-scoped actions (check-login,recent-commands,sessions) declare nowhen. Core'sreadAcrossHostsand the operations gate skip a host only when an action'swhendoes not match, so the SSH login check ran against every host the user can reach, including ones with SSH turned off.The three host actions now declare
"when": { "settings": { "enableTerminal": true } }.enableTerminalis this plugin's hostenableKey, the SSH switch in the host editor. Core reads it with its default (enableDefault: true), so hosts that never stored it keep the check, and only hosts with SSH switched off drop it. No core change is needed.Validation: a new test checks every host-scoped action with
matchesWhenfrom the SDK. A host withenableTerminal: falseis excluded and one withtrueis included. It fails on the previous manifest. Full suite: 677 passed. Typecheck, build, manifest validation and prettier pass. Not tested end to end in a running Termix.