Skip to content

fix: keep the SSH login signal off hosts without an SSH terminal - #66

Merged
LukeGus merged 2 commits into
Termix-SSH:dev-1.4.1from
ZacharyZcR:fix/login-signal-ssh-hosts
Nov 16, 2026
Merged

LukeGus merged 2 commits into
Termix-SSH:dev-1.4.1from
ZacharyZcR:fix/login-signal-ssh-hosts

Conversation

@ZacharyZcR

Copy link
Copy Markdown
Member

Fixes Termix-SSH/Termix#1795 (also reported as #1800 there).

An RDP-only host, saved with SSH and status checks off, shows SSH Login: read ECONNRESET on the dashboard and the new host page right away.

That comes from this plugin's ssh-terminal.login signal. It reads ssh-terminal.check-login per host every 600 seconds. The host-scoped actions (check-login, recent-commands, sessions) declare no when. Core's readAcrossHosts and the operations gate skip a host only when an action's when does not match, so the SSH login check ran against every host the user can reach, including ones with SSH turned off.

The three host actions now declare "when": { "settings": { "enableTerminal": true } }. enableTerminal is this plugin's host enableKey, the SSH switch in the host editor. Core reads it with its default (enableDefault: true), so hosts that never stored it keep the check, and only hosts with SSH switched off drop it. No core change is needed.

Validation: a new test checks every host-scoped action with matchesWhen from the SDK. A host with enableTerminal: false is excluded and one with true is included. It fails on the previous manifest. Full suite: 677 passed. Typecheck, build, manifest validation and prettier pass. Not tested end to end in a running Termix.

The SSH login signal reads ssh-terminal.check-login on every host the user
can reach, every ten minutes. Its actions had no when rule, so core ran them
on RDP-only hosts too, and the dashboard and host page showed an SSH login
error for a host that has SSH turned off.

The host actions now apply only where enableTerminal is on. Core already
skips a host whose settings do not match an action's when rule. Hosts that
never set it read the default, which is on.

Fixes Termix-SSH/Termix#1795
@termix-triage-bot

termix-triage-bot Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

AI review | Looks safe to merge

The PR adds a when condition to three host-scoped actions in manifest.json to skip SSH terminal checks on hosts where the feature is disabled, and includes a test to verify the behavior. The change is safe, follows plugin standards, and correctly resolves the reported issue.

Reviewed af615e1. AI can be wrong, a maintainer still decides. Comment /termix review to run it again.

@LukeGus
LukeGus changed the base branch from main to dev-1.4.1 November 16, 2026 23:18

@LukeGus LukeGus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LukeGus
LukeGus merged commit 9fd71fa into Termix-SSH:dev-1.4.1 Nov 16, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

new "Host Page" is connecting via SSH on RDP only hosts

2 participants