Repository navigation
feat: allow unencrypted RustDesk direct IP sessions - #72
Merged
LukeGus merged 5 commits intoNov 16, 2026
Merged
Conversation
Older RustDesk versions answer direct IP access with the password challenge straight away and never start the key exchange, so the session failed with "The remote device did not start a secure session". Add a host switch, off by default and only offered for direct IP, that lets the session carry on without encryption. With the switch off the error now says what happened and how to allow it.
|
AI review | Looks safe to merge Adds a host setting to allow unencrypted direct IP sessions for older RustDesk versions that skip the key exchange. The change safely scopes the option to direct connections, updates the handshake to handle the raw frame, and includes tests and documentation. No security issues, bugs, or rule violations found. Reviewed 0d621fb. AI can be wrong, a maintainer still decides. Comment |
# Conflicts: # CHANGELOG.md # manifest.json # package-lock.json # package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Older RustDesk versions answer direct IP access (port 21118) with the
password challenge straight away and never start the key exchange. The
plugin expects a signed ID first, so these devices can't be reached by
direct IP at all:
The RustDesk app itself connects to the same devices by IP without issue.
I hit this with a fleet of Raspberry Pis (Raspberry Pi OS 10 Buster) that
are only reachable over a VPN.
Change
offered when Direct IP access is on. With it on, a direct peer that skips
the key exchange is accepted and the session carries on without
encryption.
encryption and that it can be allowed on the host.
unless Direct IP access is on.
locales/en.jsonis touched; translations and thechangelog are left for the release.
Testing
it otherwise; settings read, import and pass the switch only for direct
IP; the host editor shows the switch only for direct IP.
npm run test,typecheck,build,validateandformat:checkpass.devices.