Skip to content

feat: allow unencrypted RustDesk direct IP sessions - #72

Merged
LukeGus merged 5 commits into
Termix-SSH:dev-1.4.2from
Kirill-INQ:feat/rustdesk-plain-direct
Nov 16, 2026
Merged

LukeGus merged 5 commits into
Termix-SSH:dev-1.4.2from
Kirill-INQ:feat/rustdesk-plain-direct

Conversation

@Kirill-INQ

Copy link
Copy Markdown

Problem

Older RustDesk versions answer direct IP access (port 21118) with the
password challenge straight away and never start the key exchange. The
plugin expects a signed ID first, so these devices can't be reached by
direct IP at all:

RustDesk connection failed: The remote device did not start a secure session

The RustDesk app itself connects to the same devices by IP without issue.
I hit this with a fleet of Raspberry Pis (Raspberry Pi OS 10 Buster) that
are only reachable over a VPN.

Change

  • New host switch Allow unencrypted sessions, off by default and only
    offered when Direct IP access is on. With it on, a direct peer that skips
    the key exchange is accepted and the session carries on without
    encryption.
  • With the switch off, the error now says the device answered without
    encryption and that it can be allowed on the host.
  • Sessions through an ID server are not affected: the switch is ignored
    unless Direct IP access is on.
  • Docs updated. Only locales/en.json is touched; translations and the
    changelog are left for the release.

Testing

  • New tests: client logs in to a plain direct peer when allowed and refuses
    it otherwise; settings read, import and pass the switch only for direct
    IP; the host editor shows the switch only for direct IP.
  • npm run test, typecheck, build, validate and format:check pass.
  • The same handshake change, applied by hand to 1.4.0, connects to the real
    devices.

LukeGus and others added 4 commits November 12, 2026 16:18
Older RustDesk versions answer direct IP access with the password
challenge straight away and never start the key exchange, so the
session failed with "The remote device did not start a secure session".

Add a host switch, off by default and only offered for direct IP, that
lets the session carry on without encryption. With the switch off the
error now says what happened and how to allow it.
@termix-triage-bot

termix-triage-bot Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

AI review | Looks safe to merge

Adds a host setting to allow unencrypted direct IP sessions for older RustDesk versions that skip the key exchange. The change safely scopes the option to direct connections, updates the handshake to handle the raw frame, and includes tests and documentation. No security issues, bugs, or rule violations found.

Reviewed 0d621fb. AI can be wrong, a maintainer still decides. Comment /termix review to run it again.

@LukeGus
LukeGus changed the base branch from main to dev-1.4.2 November 16, 2026 23:18
# Conflicts:
#	CHANGELOG.md
#	manifest.json
#	package-lock.json
#	package.json

@LukeGus LukeGus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LukeGus
LukeGus merged commit 1927691 into Termix-SSH:dev-1.4.2 Nov 16, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants