Repository navigation
fix: split a DOMAIN\user RDP login into domain and username - #65
Merged
Merged
Conversation
|
AI review | Looks safe to merge The PR adds a helper to split DOMAIN\user RDP credentials into separate domain and username fields when the domain is not already set, preserving explicit domains and UPN formats. Tests cover the new logic and no security or stability issues were found. Reviewed 7b45006. AI can be wrong, a maintainer still decides. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #63
guacd and the built-in engine both send the RDP username as typed, so
CORP\alicewith an empty domain field fails authentication.createRdpTokennow splits aDOMAIN\userlogin intodomainandusernamewhen no domain is set. Saved hosts and quick connect both go through it.Left alone on purpose:
user@domainstays a UPN, since its suffix isn't necessarily the NetBIOS domain and NLA accepts the UPN as is.Test:
tests/backend/token-service.test.tscovers the split, the explicit domain and the UPN case.