Skip to content

fix: split a DOMAIN\user RDP login into domain and username - #65

Merged
LukeGus merged 1 commit into
Termix-SSH:dev-1.4.2from
ZacharyZcR:fix/rdp-domain-username
Nov 16, 2026
Merged

LukeGus merged 1 commit into
Termix-SSH:dev-1.4.2from
ZacharyZcR:fix/rdp-domain-username

Conversation

@ZacharyZcR

Copy link
Copy Markdown
Member

Fixes #63

guacd and the built-in engine both send the RDP username as typed, so CORP\alice with an empty domain field fails authentication. createRdpToken now splits a DOMAIN\user login into domain and username when no domain is set. Saved hosts and quick connect both go through it.

Left alone on purpose:

  • a login with the domain field already filled keeps both values as entered;
  • user@domain stays a UPN, since its suffix isn't necessarily the NetBIOS domain and NLA accepts the UPN as is.

Test: tests/backend/token-service.test.ts covers the split, the explicit domain and the UPN case.

@termix-triage-bot

termix-triage-bot Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

AI review | Looks safe to merge

The PR adds a helper to split DOMAIN\user RDP credentials into separate domain and username fields when the domain is not already set, preserving explicit domains and UPN formats. Tests cover the new logic and no security or stability issues were found.

Reviewed 7b45006. AI can be wrong, a maintainer still decides. Comment /termix review to run it again.

@termix-ci
termix-ci Bot deleted the branch Termix-SSH:dev-1.4.1 November 15, 2026 19:35
@ZacharyZcR
ZacharyZcR changed the base branch from dev-1.4.1 to dev-1.4.2 November 16, 2026 13:25

@LukeGus LukeGus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LukeGus
LukeGus merged commit 1c5df80 into Termix-SSH:dev-1.4.2 Nov 16, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants