Skip to content

fix: decode RemoteFX Progressive from Windows without dropping RDP - #49

Merged
LukeGus merged 1 commit into
Termix-SSH:dev-1.4.2from
ZacharyZcR:fix/gfx-progressive-decode
Nov 15, 2026
Merged

LukeGus merged 1 commit into
Termix-SSH:dev-1.4.2from
ZacharyZcR:fix/gfx-progressive-decode

Conversation

@ZacharyZcR

@ZacharyZcR ZacharyZcR commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

Fixes #45, #46, #48: RDP to Windows drops since 26.11.1 / Remote Desktop 1.4.0, for example on opening the Start menu or OBS, with

ironrdp_egfx::client::GraphicsPipelineClient::handle_wire_to_surface2 … "rfx progressive decode failed"

1.4.0 negotiates the graphics pipeline (#37). Windows then sends RemoteFX Progressive tiles even with only the V8 capability set the engine advertises. The pinned IronRDP (62246b3) fails on their SRL upgrade streams, and the error ends the session. External guacd (FreeRDP) is unaffected, which matches the reports.

Reproduced on a fresh Windows 10 22H2 VM with wallpaper on, opening the Start menu and Edge. A diagnostic build that surfaced the decoder error showed Srl(MissingTerminator), then Srl(Truncated) and Srl(ZeroRunTooLong) once each was relaxed. Windows ends an SRL stream at its last code word. There is no trailing zero byte and no zero padding, and the coefficients past the end are zeros. IronRDP required the terminator and failed when reading past the end. FreeRDP reads past the end as zero bits.

IronRDP already fixed this upstream: Devolutions/IronRDP#2134, "decode Windows SRL streams without their trailing zeros", in 1f69e124e. That commit is 19 commits ahead of the pinned rev, on the same line. It also includes Devolutions/IronRDP#1789, which drops a surface update it cannot decode instead of the session, so a future codec gap shows as a stale region rather than a disconnect. This moves every IronRDP dependency to 1f69e124e rather than master, which is 208 commits ahead. The lock file changes only the 20 IronRDP crate sources. The engine code needs no change and builds --locked without warnings. The bundled engine is rebuilt with the pinned wasm-bindgen 0.2.104.

Validation:

  • Against the Windows VM, before: 3 of 3 runs dropped within a second of logon. After: 6 of 6 runs stayed up through repeated Start menu opens and Edge, drawing 4.5–6.3 MB each, with no warnings. The final screenshot shows Edge's photo background and icons rendered correctly.
  • Native Rust tests, all 561 plugin tests (1 skipped), typecheck, build and manifest validation pass.

Rebased onto dev-1.4.1, so it can ship in 1.4.1. The IronRDP crates were updated on their own (cargo update -p for each), so the security updates on dev (1f0fde1) stay in the lock file unchanged. Native Rust tests, all 574 plugin tests (1 skipped), typecheck, build and validation pass on the rebased branch. The engine is built from the same IronRDP commit that passed the Windows runs above. The dev changes (KDC worker, plugin process) are on the TypeScript side.

#46 has since collected reports from Windows Server 2019/2022 and Windows 11, all fixed by rolling back to 1.3.1. #63 switched to external guacd for the same reason.

Note: #43 and #44 also rebuild engine_bg.wasm and source-hash.txt. Whichever lands later needs npm run build:engine again.

@termix-triage-bot

termix-triage-bot Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

AI review | Looks safe to merge

Updates the IronRDP dependency to a specific upstream commit to fix RemoteFX Progressive decoding failures on Windows, and updates the bundled engine source hash. The change is safe and follows repo conventions.

Partial review: 1 file(s) could not be read, a maintainer should look at them.

Reviewed 18a7ce2. AI can be wrong, a maintainer still decides. Comment /termix review to run it again.

@bankir82 bankir82 mentioned this pull request Nov 13, 2026
Since the built-in engine negotiates the graphics pipeline (1.4.0), Windows
sends RemoteFX Progressive tiles. The pinned IronRDP rejected the SRL
streams in their upgrade passes, which Windows ends at the last code word
without a trailing zero byte, and the error ended the session: opening the
Start menu, OBS or a page with images dropped the connection with
"rfx progressive decode failed".

Move IronRDP to 1f69e124e, which reads SRL streams the way FreeRDP does
(Devolutions/IronRDP#2134) and drops a surface update it cannot decode
instead of the session (#1789). Only the IronRDP crates change in the lock
file. Rebuilt the bundled engine.

Fixes Termix-SSH#45
Fixes Termix-SSH#46
Fixes Termix-SSH#48
@ZacharyZcR
ZacharyZcR force-pushed the fix/gfx-progressive-decode branch from a5fa8be to 18a7ce2 Compare November 14, 2026 11:00
@ZacharyZcR
ZacharyZcR changed the base branch from main to dev-1.4.1 November 14, 2026 11:00
@ZacharyZcR

Copy link
Copy Markdown
Member Author

@LukeGus This one fixes the progressive decode drops in #46 (several users are rolled back to 1.3.1), so it would be great to get it into 1.4.1. The failing authz check here and on Termix-SSH/Termix#1790, #1791, #1806 and #1807 fails the same way on a clean dev-26.11.2 locally: TOTP is still 1.0.2 (plugin API 1) in docker/bundled-plugins.json, and dev no longer runs API 1 plugins, so the seed's /plugin-api/totp/setup gets a 503.

@LukeGus
LukeGus changed the base branch from dev-1.4.1 to dev-1.4.2 November 15, 2026 19:12
@LukeGus
LukeGus merged commit face55b into Termix-SSH:dev-1.4.2 Nov 15, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RDP connection issue

2 participants