fix(dashboard): theme confirmation dialogs via App.useApp() - #442
Merged
jubaoliang merged 3 commits intoAug 27, 2026
Merged
Conversation
…dialogs - Added `modal` utility from `antdModal` to replace direct `Modal` calls across various components, ensuring a unified approach to confirmation dialogs. - Updated components to utilize the new `modal.confirm` method, enhancing maintainability and consistency in user interactions. - Removed direct imports of `Modal` from `antd` in favor of the new utility, streamlining the codebase. This change improves the user experience by standardizing modal behavior and appearance throughout the application.
- Replaced direct imports of `message` and `modal` from utility files with `App.useApp()` in various components, promoting a consistent approach to accessing application-wide functionalities. - Updated components to utilize the new structure, enhancing maintainability and reducing redundancy in imports. This change streamlines the codebase and improves the overall architecture of the dashboard components.
liukewia
marked this pull request as draft
August 26, 2026 12:30
liukewia
marked this pull request as ready for review
August 27, 2026 02:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
modalfrom<App>(same pattern asantdMessage) so confirmation dialogs inherit ConfigProvider theme instead of using staticModal.confirm.App.useApp()and keep non-hook helpers (confirmModal) on the boundmodalproxy.onnxDownloadProgressi18n keys in favor ofonnxDownloadingduring local model download.Target branch
develop(feature / fix — default)main(release/*orhotfix/*only)Type of change
Test plan
Confirm dialogs (delete provider, storage backend, skills, etc.) follow the current dashboard theme (light/dark).
Destructive confirms still show danger OK and complete the same API calls as before.
make allpasses locallyAdded/updated tests
Checklist
CHANGELOG.md(if user-facing)Made with Cursor