Conversation
|
No findings. The PR description documents sufficient testing, including representative real-CLI E2E verification for the runtime behavior change. |
jeff-r2026
requested changes
Oct 3, 2026
| For manual feedback, use `teamai recall feedback --positive <docId>` or | ||
| `--negative <docId>`. With the global `--dry-run`, it only previews the requested | ||
| feedback: votes and config stay unchanged, including legacy migrations. It does | ||
| not check whether a negative vote can reduce the count. Ordinary diagnostic |
Collaborator
There was a problem hiding this comment.
Please do not modify this skill
|
No findings. The PR description documents sufficient testing, including representative real-CLI E2E verification for the runtime behavior change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
recall feedback --positive/--negative --dry-runpreview the requested feedback instead of recording a vote.Type of Change
Test Plan
Local macOS, Node 26.7.0:
npm run buildnpx tsc --noEmitnpm run lintnpm exec --yes --package=npm@11.6.0 -- node node_modules/vitest/vitest.mjs run --maxWorkers=4— 370 files passed; 7,172 tests passed, 1 skipped.npx vitest run commands-reference -u— passed; generated reference unchanged because this reuses the existing global option.npx vitest run --config vitest.e2e.config.ts src/__tests__/e2e/recall-feedback-dry-run.test.ts --retry=0— 13 passed.git diff --cached --checkThe E2E tests launch the built
dist/index.jsin isolated user/project scopes. Positive and negative previews work with the flag before or after the command, preserving config, votes and directory inventories. Legacy votes stay unchanged, missing votes are not created, and an unreadable project config still fails rather than falling back to user scope. Without the flag, votes change from 2 to 3 and back to 2 in the selected scope. Ordinary diagnostic logging is excluded from the filesystem comparison.Before the runtime fix, the new test file had 10 failures and 3 passes on upstream
b0ce1f2; all 13 pass with the fix. The first full-suite run under npm 12 hit the existing package-content test's assumption thatnpm pack --jsonreturns an array. Re-running under npm 11 passed; that unrelated test was not changed.Related Issues
Refs #900 (D:
recall feedbackonly; the other dry-run items remain open).Notes for Reviewers
The preview reports the requested action, not a predicted vote count. Existing vote storage, locking and normal feedback behavior are unchanged.