Repository navigation
Conversation
liuhedev
marked this pull request as ready for review
October 30, 2026 06:18
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every Agent Window currently labels its native tab group
BrowserSkill, so concurrent tasks are indistinguishable. This change reusesbsk session start --nameas the group title, while retaining its existing use in local operation history.The group's title becomes
账户变更. Names are trimmed for display; omitted or whitespace-only names retainBrowserSkill. No additional CLI flag is needed.The daemon forwards the optional
task_namefield throughtool.session_start; the extension retains it in the session context and uses it when reconciling its own group. The protocol schema, CLI help, and documentation are updated. Group ownership, orange color, collapsed-state preservation, and page-control rules are unchanged. Both the daemon and extension need the update; older peers retain the default title.Validation
git diff --check: passed.账户变更账户变更日志排查日志排查BrowserSkillBrowserSkillAll four sessions received distinct groups. A newly claimed tab joined its session's group without changing its title or expanding a collapsed group. A non-string task name was rejected.
Validation gap: the full CLI/daemon build could not complete locally because the
aws-lc-sysdependency was unavailable in the local cache and dependency downloads were unreliable. The live browser check covers the extension handler through the native group APIs, rather than a complete CLI-to-daemon-to-extension round trip. The Draft PR is pending the repository's CI and maintainer review.