Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Web applications often require a continuous press, optional hold, movement and release. Add
bsk drag/tool.dragso these interactions run as one bounded native-input operation, with VOM refs identifying elements even when names repeat.Implementation
Examples:
Validation
Fixtures live in
evals/browser/cases/regression/drag-interactions. Assertions check DOM order, values, pixels, trusted events and native DataTransfer contents, including duplicate-name refs, stale observations, covered/detached elements, cancellation and background tabs. CI runs the browser suite and installed-extension runner and retains evidence.Self-review covered input ownership, cancellation races, attachment replacement, selector ambiguity, observation expiry and shared-control destination checks. Test dependencies are pinned and reuse the existing build-tool version.
Scope
Desktop mouse gestures within one tab, with both endpoints visible after initial scrolling. No scrolling while holding or touch gestures. Cross-origin frame refs support default action points and relative movement; custom offsets within those frames are rejected. Successful input delivery still requires observing the application result; cancellation does not roll back changes already made by the page.
CI follow-up
Keep the skill entry below its existing 7,100-byte budget under both LF and CRLF. Fix an existing remote-server integration-test race: receiving a WebSocket close frame precedes release of the browser capacity slot, so the final connection waits at most three seconds and retries only the exact capacity response. Add operation context to authorization filesystem errors to diagnose a separate intermittent Windows access-denied failure without changing storage behavior. Local script tests (18), authorization tests (6), remote-server integration tests (6), formatting and Clippy pass.
Review fixes
Added regression coverage for nested frame occlusion, projection and stale frame identity, positive/negative source offsets, covered/moved/outside offset points, and combined editable/clickable drag semantics. The installed-extension runner verifies exact Canvas input coordinates/pixels, source and destination offsets, normal fill/click actions on draggable cards, blocked nested-frame drops with zero presses/drops, and successful unobstructed native drops.