Repository navigation
fix: end browser tasks when controlled tabs leave their window - #510
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving a controlled tab out of its Agent Window previously broke the task while leaving control indicators visible. End the entire session on that move, preserve every page in its current location, and remove overlays, native task groups, and CDP ownership. The ended session cannot resume.
user_moved_tabreason. Guard asynchronous cleanup so it cannot close or move pages after release. Clean up pending debugger attachments while preserving connections owned by another live session; bind snapshot frame reads to their original attachment so cancelled reads cannot reconnect or use a replacement connection.session_stopretain their behavior. Finish source lookups before the final control check so user input or a pause still prevents a pending move.Compatibility: protocol 1.6 is required by the new extension so older daemons cannot silently ignore session termination. Update the CLI/daemon together with the extension; connecting to an older daemon shows an explicit upgrade message.
Validation:
auto_spawn. Standalone reruns passed all fourauto_spawntests on both2374f0aand46a0ba4; the initial failure could not be reproduced consistently.Access is denied, OS error 5), before any session or tool dispatch. Later steps in that job did not run.