Skip to content

fix: add path validation in main.js (CWE-22) #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anupamme wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: add path validation in main.js (CWE-22) #110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -920,22 +920,27 @@ ${bridgeCode}
}

// Validate path (UNC paths on Windows, absolute paths in Docker)
// Normalize temp dir path for comparison
const normalizedTempDir = os.tmpdir().replace(/\\/g, '/');
// Normalize path for comparison; use resolved (canonicalized) paths so
// '../' traversal sequences cannot spoof the temp/server-managed checks.
const normalizedFilePath = actualFilePath.replace(/\\/g, '/');
let isServerManagedPath = false;
let isTempFile = false;
try {
const resolvedFilePath = path.resolve(actualFilePath);
const resolvedUserData = path.resolve(app.getPath('userData'));
const resolvedDbDir = path.resolve(path.dirname(getDatabasePath()));
const resolvedTempDir = path.resolve(os.tmpdir());
isServerManagedPath =
resolvedFilePath === resolvedDbDir ||
resolvedFilePath.startsWith(resolvedUserData + path.sep) ||
resolvedFilePath.startsWith(resolvedDbDir + path.sep);
isTempFile =
resolvedFilePath === resolvedTempDir ||
resolvedFilePath.startsWith(resolvedTempDir + path.sep);
} catch (error) {
isServerManagedPath = false;
isTempFile = false;
}
const isTempFile = normalizedFilePath.includes(normalizedTempDir);

if (isDockerContainer()) {
// In Docker, require absolute paths starting with /
Expand Down
Loading