Add optional judgement counts to score responses - #1
Merged
Merged
Conversation
Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add nullable
perfectStar,perfect,great,good,bad, andmissfields toPlatformScoreEntryfor the existing account/scoresAPI. Null represents missing judgement data or a best-score snapshot. This is an additive JSON contract change.Validation:
SiriusData.slnRelease build passed for .NET 8 and .NET 10; the MasterMemory tool passed a byte-exact round-trip on a small native fixture. The matching SiriusServer branch passed its Release build and all 48 tests with PostgreSQL integration enabled.Companion implementation: SiriusServer #13. Merge/build this shared contract before the server change.
中文说明
为
PlatformScoreEntry增加可空的perfectStar、perfect、great、good、bad、miss字段，供原有账号/scores接口返回判定数量。null表示没有可用判定数据，或该条记录属于最佳成绩快照。这是向 JSON 契约追加字段的兼容性修改。验证：
SiriusData.sln的 .NET 8、.NET 10 Release 构建通过；MasterMemory 工具对小型原生测试数据完成了字节一致的往返校验。对应 SiriusServer 分支的 Release 构建及启用 PostgreSQL 集成测试后的 48 项测试均通过。配套实现：SiriusServer #13。请先合并并构建本共享协议修改，再合并服务端修改。