[YouTube] Remove deprecated throttling decryption code#901
Merged
litetex merged 2 commits intoTeamNewPipe:devfrom Aug 22, 2022
Merged
Conversation
YoutubeThrottlingDecrypter is now a non-instantiable final class and non-static attributes have been removed. The static attributes of this class have been renamed, in order to respect the naming specification used.
opusforlife2
added
the
code quality
litetex
requested changes
Aug 21, 2022
Member
litetex
left a comment
litetex
left a comment
There was a problem hiding this comment.
The deprecation is fine but the other stuff introduced here not so much...
AudricV
force-pushed
the
remove-deprecated-code-yt-throttling-decrypter
branch
from
9b738c5 to
03d9a4f
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't test the changes but the changes made in this pull request should not affect the app as throttling decryption is only performed by the extractor.
This PR removes the deprecated code of
YoutubeThrottlingDecrypter, deprecated officially since v0.22.0 (with #786), released on April 16th (so more than four months ago).It also fixes typos in the Javadoc of the method used to perform the throttling decryption in
YoutubeStreamExtractor,tryDecryptUrl(String, String), as pointed in #891 (review).