Skip to content

Use Objects.requireNonNull().#877

Merged
Stypox merged 1 commit intoTeamNewPipe:devfrom
Isira-Seneviratne:Use_Objects_requireNonNull
Aug 3, 2022
Merged

Use Objects.requireNonNull().#877
Stypox merged 1 commit intoTeamNewPipe:devfrom
Isira-Seneviratne:Use_Objects_requireNonNull

Conversation

@Isira-Seneviratne
Copy link
Copy Markdown
Member

@Isira-Seneviratne Isira-Seneviratne commented Jul 27, 2022 •
edited
Loading

litetex
litetex approved these changes Jul 30, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@litetex litetex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Stypox Stypox merged commit 4a4939d into TeamNewPipe:dev Aug 3, 2022
@Isira-Seneviratne Isira-Seneviratne deleted the Use_Objects_requireNonNull branch August 3, 2022 23:47
@Stypox
Copy link
Copy Markdown
Member

Stypox commented Aug 4, 2022

This actually broke three tests, since now NullPointerException is (correctly) thrown instead of IllegalArgumentException. I'm fixing them in #882, but please take a look at tests when making PRs here.

Stypox added a commit to litetex/NewPipeExtractor that referenced this pull request Aug 4, 2022
@Stypox
Fix test about exception type: NPE, not IllegalArgment
efa8090 
The relevant change was made in TeamNewPipe#877
@Isira-Seneviratne
Copy link
Copy Markdown
Member Author

Isira-Seneviratne commented Aug 4, 2022

This actually broke three tests, since now NullPointerException is (correctly) thrown instead of IllegalArgumentException. I'm fixing them in #882, but please take a look at tests when making PRs here.

My bad 😅

litetex pushed a commit to litetex/NewPipeExtractor that referenced this pull request Aug 14, 2022
@Stypox @litetex
Fix test about exception type: NPE, not IllegalArgment
17bad6c 
The relevant change was made in TeamNewPipe#877
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Stypox Stypox Stypox approved these changes

@litetex litetex litetex approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Isira-Seneviratne @Stypox @litetex