Conversation
litetex
left a comment
There was a problem hiding this comment.
2 points I have to discuss here:
- All tests are failing there seems to be something wrong
- What are the changes in the new "version"?
|
I just want to add that the current fork of nanojson uses significantly more CPU than upstream! In Piped, I'm now using a personal fork since TeamPiped/Piped-Backend#357, the difference is MASSIVE! I did this after seeing that nanojson was using a lot of CPU in the I don't have a before screenshot, but here's the after (it was ~1800 seconds before, after 10 minutes of recording/profiling): |
|
@FireMasterK If the only difference between this version and your fork is upstream changes, could they not be added to this fork? |
I suppose they could, but I only tested it on YouTube (in Piped), I'm not sure if other services require the JS json extraction. In my fork, I have the upstream changes and have cherry-picked only this commit: TeamNewPipe/nanojson@d5da581 |
|
Closing in favor of #981. Thanks @FireMasterK for the heads-up! |

Update our fork of nanojson. This includes a few dependency updates as well as smaller improvements from upstream.