[YouTube] Fix duration and live stream display in related videos #1478
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,103 @@ | ||
| { | ||
| "contentImage": { | ||
| "thumbnailViewModel": { | ||
| "image": { | ||
| "sources": [ | ||
| { | ||
| "url": "https://i.ytimg.com/vi/LIVE_VIDEO_ID/hqdefault.jpg", | ||
| "width": 168, | ||
| "height": 94 | ||
| }, | ||
| { | ||
| "url": "https://i.ytimg.com/vi/LIVE_VIDEO_ID/hqdefault.jpg", | ||
| "width": 336, | ||
| "height": 188 | ||
| } | ||
| ] | ||
| }, | ||
| "overlays": [ | ||
| { | ||
| "thumbnailBottomOverlayViewModel": { | ||
| "badges": [ | ||
| { | ||
| "thumbnailBadgeViewModel": { | ||
| "badgeStyle": "THUMBNAIL_OVERLAY_BADGE_STYLE_LIVE", | ||
| "text": "LIVE" | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| { | ||
| "thumbnailHoverOverlayToggleActionsViewModel": { | ||
| "buttons": [] | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| "metadata": { | ||
| "lockupMetadataViewModel": { | ||
| "title": { | ||
| "content": "LIVE_VIDEO_TITLE" | ||
| }, | ||
| "image": { | ||
| "decoratedAvatarViewModel": { | ||
| "avatar": { | ||
| "avatarViewModel": { | ||
| "image": { | ||
| "sources": [ | ||
| { | ||
| "url": "https://yt3.ggpht.com/AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA==", | ||
| "width": 68, | ||
| "height": 68 | ||
| } | ||
| ] | ||
| }, | ||
| "avatarImageSize": "AVATAR_SIZE_M" | ||
| } | ||
| }, | ||
| "a11yLabel": "Go to channel", | ||
| "rendererContext": { | ||
| "commandContext": { | ||
| "onTap": { | ||
| "innertubeCommand": { | ||
| "commandMetadata": { | ||
| "webCommandMetadata": { | ||
| "url": "/@LIVE_CHANNEL_HANDLE" | ||
| } | ||
| }, | ||
| "browseEndpoint": { | ||
| "browseId": "UCD_on7-zu7Zuc3zissQvrgw", | ||
| "canonicalBaseUrl": "/@LIVE_CHANNEL_HANDLE" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "metadata": { | ||
| "contentMetadataViewModel": { | ||
| "metadataRows": [ | ||
| { | ||
| "metadataParts": [ | ||
| { | ||
| "text": { | ||
| "content": "LIVE_CHANNEL_NAME", | ||
| "styleRuns": [], | ||
| "attachmentRuns": [] | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| ], | ||
| "delimiter": " • " | ||
| } | ||
| }, | ||
| "menuButton": {} | ||
| } | ||
| }, | ||
| "contentId": "LIVE_VIDEO_ID", | ||
| "contentType": "LOCKUP_CONTENT_TYPE_VIDEO" | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not understand this change. Why exclude shorts here? If
SHORTSis passed, it will fail inconvertDurationToInt.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YouTube does something special with shorts in certain places, instead of showing the numeric duration in the corner of the thumbnail, it simply shows the word SHORTS
SHORTS does not actually fail in convertDurationToInt, and that is precisely why the check exists.
Without the !input.equalsIgnoreCase("SHORTS") guard: parseDurationString("SHORTS") would hit this line first
It would throw immediately, never reaching convertDurationToInt at all.
The check is not there to exclude shorts, but to allow them thrugh so that the downstream fallback (returning 0) can handle the case where YouTube sends SHORTS instead of an actual timestamp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yeah, I see. Thank you.