[YouTube] Fix nsig parsing, fix timestamps being turned to text, fix tests#1443
Merged
Stypox merged 8 commits intoTeamNewPipe:devfrom Jan 28, 2026
Merged
[YouTube] Fix nsig parsing, fix timestamps being turned to text, fix tests#1443Stypox merged 8 commits intoTeamNewPipe:devfrom
Stypox merged 8 commits intoTeamNewPipe:devfrom
Conversation
One of the tests had to be removed since I could not find a channel which has that message, and according to https://youtube.fandom.com/wiki/Termination#Ban_Messages that message is "deprecated" so maybe it does not exist anymore.
Now YouTube returns just "{}" without any better explanation, so ParsingException is thrown by the extractor. Now users won't get told that the video they are trying to watch does not exist at all, but since YouTube literally provides an empty JSON response we have no way to detect if the video does not exist or if there is some other bug in the way we make requests that causes an empty response.
Member
Author
|
I'm merging now to do the hotfix release, feel free to leave a review later and I will take care of addressing any issues |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #1438
This is the timestamp fix:
For the n-sig parsing, I took inspiration from https://github.com/yt-dlp/yt-dlp/blob/e08fdaaec2b253abb1e08899d1d13ec5072d76f2/yt_dlp/extractor/youtube/jsc/_builtin/vendor/yt.solver.core.js#L86 and yt-dlp/ejs@e91d03f . The test now passes and the function gets extracted correctly, though I didn't test if the signatures are actually deobfuscated properly, since they are now used anywhere at the moment.