Skip to content

Use java 21 toolchain on whole extractor and set java via release#1440

Closed
ghost wants to merge 1 commit intodevfrom
unknown repository
Closed

Use java 21 toolchain on whole extractor and set java via release#1440
ghost wants to merge 1 commit intodevfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Jan 26, 2026

Toolchain specifies which exact jdk version used for compiling gradle projects. Using several different toolchains in one repo without any reason is wastedul. Unifying used jdk will allow to store only one jdk on dev side. As a side effect unification should make problem encountered by some users on Matrix (it was tried to solve it in #12923)

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

Toolchain specifies which exact jdk version used for compiling gradle
projects. Using several different toolchains in one repo without any
reason is wastedul. Unifying used jdk will allow to store only one
jdk on dev side. As a side effect unification should make problem
encountered by some users on Matrix (it was tried to solve it
in #12923)
@ghost
Copy link
Copy Markdown
Author

ghost commented Jan 26, 2026

@ghost
Copy link
Copy Markdown
Author

ghost commented Jan 26, 2026

Both extractor and newpipe probably should use the same toolchain version and just set different language versions..(?)

@ghost
Copy link
Copy Markdown
Author

ghost commented Jan 26, 2026

CC @theimpulson @AudricV

@FireMasterK
Copy link
Copy Markdown
Member

Does android and its desugaring support Java 21? I am interested in this as well, but that's my main concern as to breakages over there.

@ghost
Copy link
Copy Markdown
Author

ghost commented Mar 28, 2026

Does android and its desugaring support Java 21? I am interested in this as well, but that's my main concern as to breakages over there.

The PR is about just using jdk 21 everywhere but it doesn't mean you will be able to use 21 features. You will still use java 11 but just will need only one jdk installed not two for everything to work properly

@ghost ghost closed this by deleting the head repository Mar 30, 2026
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant