Conversation
Adding a module as implementation adds it as a dependency in the published jar's POM file Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
theimpulson
force-pushed
the
jarFixes
branch
from
5914f67 to
1ec2818
Compare
TobiGr
approved these changes
Dec 25, 2025
Contributor
TobiGr
left a comment
TobiGr
left a comment
There was a problem hiding this comment.
LGTM. I looked at the generated jar and also tested the jitpack build for this PR
Member
Author
|
Seems I cannot merge due to snyk failing to scan for issues nor I can see the issues. |
Contributor
|
I forgot to merge. snyk is failing because the build.gradle files are not avaialble on this branch (konverted to .kts). However, I cannot change the check to kts because they are not yet avaialble on dev 🥳 This will be fixed once dev is merged to master. I'll remove the requirement for those checks to pass for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a module as implementation adds it as a dependency in the published jar's POM file