[YouTube] Extract shorts thumbnails from thumbnailViewModel#1417
Merged
TobiGr merged 1 commit intoTeamNewPipe:devfrom Dec 15, 2025
Merged
[YouTube] Extract shorts thumbnails from thumbnailViewModel#1417TobiGr merged 1 commit intoTeamNewPipe:devfrom
thumbnailViewModel#1417TobiGr merged 1 commit intoTeamNewPipe:devfrom
Conversation
Contributor
|
Thank you! I still get valid thumbails sometimes. Looks like this change is curerntly A/B tested. Could you add a check that extracts depending on whether there is a |
FineFindus
force-pushed
the
fix/short-thumbnails
branch
from
5e9ab00 to
e3f053b
Compare
Contributor
Author
|
Of course. I assumed it was already fully rolled out, otherwise I would've kept the original code. |
TobiGr
reviewed
Dec 15, 2025
FineFindus
force-pushed
the
fix/short-thumbnails
branch
from
e3f053b to
e97dbb8
Compare
Fixes an issue, where shorts thumbnails where not extracted, as they're now contained within a `thumbnailViewModel`, instead of a simple `thumbnail` object. Closes: TeamNewPipe/NewPipe#12907
FineFindus
force-pushed
the
fix/short-thumbnails
branch
from
e97dbb8 to
f987c1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue, where shorts thumbnails where not extracted, as they're now contained within a
thumbnailViewModel, instead of a simplethumbnailobject.Closes: TeamNewPipe/NewPipe#12907