[YouTube] extract additional stream information#1412
Merged
TobiGr merged 3 commits intoTeamNewPipe:devfrom Nov 30, 2025
Merged
Conversation
Implements support for checking whether an extracted audio format is using dynamic range compression (DRC). Ref: https://en.wikipedia.org/wiki/Dynamic_range_compression
FineFindus
force-pushed
the
feat/additional-itag-data
branch
from
f36ef21 to
6a7ef46
Compare
TobiGr
reviewed
Nov 30, 2025
Contributor
There was a problem hiding this comment.
LGTM, just one small thing
Build fails:
/home/runner/work/NewPipeExtractor/NewPipeExtractor/extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/ItagItem.java:710: error: incompatible types: unexpected return value
return xtags;
^
Comment on lines
+681
to
+688
| /** | ||
| * When the stream was last modified. | ||
| * | ||
| * @return unix timestamp of when the stream was last modified | ||
| */ | ||
| public long getLastModified() { | ||
| return lastModified; | ||
| } |
Contributor
There was a problem hiding this comment.
Please add a LAST_MODIFIED_UNKNOWN constant and document its use here
Contributor
Author
There was a problem hiding this comment.
Done, though I don't think that is necessary, since every format always has a lastModified field.
Contributor
There was a problem hiding this comment.
ah, ok. I didn't know that, I just saw that there was a fallback value and thought that having documentation for it might be useful.
Extracts the `lastModified` field of format, which is need for initiating SABR playback.
Extracts the `xtags` field, which encodes additional data of the format, such as if the format is using dynamic range compression. This is required for using SABR.
FineFindus
force-pushed
the
feat/additional-itag-data
branch
from
6a7ef46 to
0617c88
Compare
TobiGr
approved these changes
Nov 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements support for extracting
lastModified,xtagsandisDrc(whether a format is using dynamic range compression) from formats. They are required for initiating SABR playback, but may also be useful on their own (e.g. to filter audio streams with DRC).Ref: TeamNewPipe/NewPipe#12248