Fix SoundCloud channel tab pagination looping on empty pages#1387
Merged
TobiGr merged 3 commits intoTeamNewPipe:devfrom Oct 15, 2025
Merged
Fix SoundCloud channel tab pagination looping on empty pages#1387TobiGr merged 3 commits intoTeamNewPipe:devfrom
TobiGr merged 3 commits intoTeamNewPipe:devfrom
Conversation
TobiGr
added
bug
Contributor
|
Hello and thank you for your contribution. Is it part of the yearly ANU comp2120 OSS assignement? |
TobiGr
approved these changes
Oct 11, 2025
Contributor
TobiGr
left a comment
TobiGr
left a comment
There was a problem hiding this comment.
The changes look good to me and are easy to understand thanks to the detailed PR description. Well done!
I added a test to check that everything is working. I'd usually ask you to do this, but we are currently having a problem with single test exectuion in SoundCloud. The tests are recorded as described in our docs.
Contributor
|
Thank you for the changes. Please do the following:
After that we are good to go! |
that1potato
force-pushed
the
issue#12251
branch
from
2b5cf9d to
f6b4283
Compare
Style fix: remove trailing space at line 28 Update MAX_EMPTY_PAGES value to 3 with proper JDoc formatting Add JavaDoc for MAX_EMPTY_PAGES Rewite getPage method to internally handle emptyItems case
gradle :extractor:test --tests "org.schabi.newpipe.extractor.services.soundcloud.SoundcloudChannelTabExtractorTest$NoEmptyNextPages" -Ddownloader=RECORDING
that1potato
force-pushed
the
issue#12251
branch
from
f6b4283 to
702f1b0
Compare
Contributor
Author
|
Hey Tobi, I have fixed the checkstyle error and squashed and reordered the commits. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #12251 in the NewPipe repo.
Summary
(extractor/src/main/java/org/schabi/newpipe/extractor/services/soundcloud/extractors/SoundcloudChannelTabExtractor.java:76).Testing