Skip to content

[YouTube] Fix view count extraction error for members first and members only shorts #1326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Stypox merged 1 commit into from
Jul 9, 2025
Merged

[YouTube] Fix view count extraction error for members first and members only shorts #1326

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions ...i/newpipe/extractor/services/youtube/extractors/YoutubeShortsLockupInfoItemExtractor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,12 @@
* for an extractor for this UI data type.
* </p>
*/
public class YoutubeShortsLockupInfoItemExtractor implements StreamInfoItemExtractor {
class YoutubeShortsLockupInfoItemExtractor implements StreamInfoItemExtractor {

@Nonnull
private final JsonObject shortsLockupViewModel;

public YoutubeShortsLockupInfoItemExtractor(@Nonnull final JsonObject shortsLockupViewModel) {
YoutubeShortsLockupInfoItemExtractor(@Nonnull final JsonObject shortsLockupViewModel) {
this.shortsLockupViewModel = shortsLockupViewModel;
}

Expand Down Expand Up @@ -93,6 +93,12 @@ public long getViewCount() throws ParsingException {
.getObject("secondaryText")
.getString("content");
if (!isNullOrEmpty(viewCountText)) {
if (viewCountText.contains("✪")) {
// If secondary text content contains ✪, this short should be a members first or a
// members only one, we can't extract its view count in this case
return -1;
}

// This approach is language dependent
if (viewCountText.toLowerCase().contains("no views")) {
return 0;
Expand Down
Loading