Skip to content

Add support for advanced content and sort filters in searches #8837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
evermind-zz wants to merge 13 commits into from
Closed

Add support for advanced content and sort filters in searches #8837

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
e2bce99
searchfilters: dynamically generate UIs and evaluate selected sort an…
evermind-zz Aug 18, 2022
651a333
searchfilters: unit test for SearchFilterLogic and BaseSearchFilterUi…
evermind-zz Oct 11, 2022
3c038aa
searchfilters: common base classes for DialogFragment based UI's
evermind-zz Oct 31, 2022
7c650f6
searchfilters: Moving DividerItem from NewPipeExtractor into NewPipe
evermind-zz Nov 22, 2022
05ffe27
searchfilters: 1st Ui: default dialog for search content and sort fil…
evermind-zz Oct 11, 2022
466ddb6
searchfilters: 2nd Ui: Action menu feel alike dialog
evermind-zz Oct 11, 2022
a0d576f
searchfilters: 3rd Ui: action based UI (enhanched legacy menu)
evermind-zz Oct 11, 2022
a434af6
searchfilters: 4th dialog: every search filter option is a Chip
evermind-zz Dec 1, 2022
8858e7e
searchfilters: ViewModel for SearchFragment* and SearchFilter*DialogF…
evermind-zz Nov 21, 2022
9451167
searchfilters: rework getTranslatedFilterString() method to use NewPi…
evermind-zz Oct 31, 2022
6bcca69
searchfilters: replace old filter interaction and integrate new dialo…
evermind-zz Aug 18, 2022
7b300ec
use FilterItem for tabs
evermind-zz Dec 30, 2023
4eb71a8
just for the build to complete -- drop commit before merge
evermind-zz Jan 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ dependencies {
// name and the commit hash with the commit hash of the (pushed) commit you want to test
// This works thanks to JitPack: https://jitpack.io/
implementation 'com.github.TeamNewPipe:nanojson:1d9e1aea9049fc9f85e68b43ba39fe7be1c1f751'
implementation 'com.github.TeamNewPipe:NewPipeExtractor:v0.23.1'
implementation 'com.github.bravenewpipe:NewPipeExtractor:67366ea7b1'
implementation 'com.github.TeamNewPipe:NoNonsense-FilePicker:5.0.0'

/** Checkstyle **/
Expand Down
3 changes: 2 additions & 1 deletion app/src/main/java/org/schabi/newpipe/fragments/list/channel/ChannelFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
import org.schabi.newpipe.extractor.channel.ChannelInfo;
import org.schabi.newpipe.extractor.exceptions.ContentNotSupportedException;
import org.schabi.newpipe.extractor.linkhandler.ListLinkHandler;
import org.schabi.newpipe.extractor.search.filter.FilterItem;
import org.schabi.newpipe.fragments.BaseStateFragment;
import org.schabi.newpipe.fragments.detail.TabAdapter;
import org.schabi.newpipe.ktx.AnimationType;
Expand Down Expand Up @@ -461,7 +462,7 @@ private void updateTabs() {
.getDefaultSharedPreferences(context);

for (final ListLinkHandler linkHandler : currentInfo.getTabs()) {
final String tab = linkHandler.getContentFilters().get(0);
final FilterItem tab = linkHandler.getContentFilters().get(0);
if (ChannelTabHelper.showChannelTab(context, preferences, tab)) {
final ChannelTabFragment channelTabFragment =
ChannelTabFragment.getInstance(serviceId, linkHandler, name);
Expand Down
Loading