Skip to content

fix: detect access units for YouTube HLS AVC1 #13440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Stypox wants to merge 1 commit into
base: dev
Choose a base branch
from
+7 −1
Open

fix: detect access units for YouTube HLS AVC1 #13440

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion app/src/main/java/org/schabi/newpipe/player/helper/PlayerDataSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,12 @@
import androidx.annotation.Nullable;

import com.google.android.exoplayer2.database.StandaloneDatabaseProvider;
import com.google.android.exoplayer2.extractor.ts.DefaultTsPayloadReaderFactory;
import com.google.android.exoplayer2.source.ProgressiveMediaSource;
import com.google.android.exoplayer2.source.SingleSampleMediaSource;
import com.google.android.exoplayer2.source.dash.DashMediaSource;
import com.google.android.exoplayer2.source.dash.DefaultDashChunkSource;
import com.google.android.exoplayer2.source.hls.DefaultHlsExtractorFactory;
import com.google.android.exoplayer2.source.hls.HlsMediaSource;
import com.google.android.exoplayer2.source.hls.playlist.DefaultHlsPlaylistTracker;
import com.google.android.exoplayer2.source.smoothstreaming.DefaultSsChunkSource;
Expand Down Expand Up @@ -175,7 +177,11 @@ public SingleSampleMediaSource.Factory getSingleSampleMediaSourceFactory() {

//region YouTube media source factories
public HlsMediaSource.Factory getYoutubeHlsMediaSourceFactory() {
return new HlsMediaSource.Factory(ytHlsCacheDataSourceFactory);
// these custom flags fix AVC1/H264 stutter on some Pixel devices, see
// https://github.com/InfinityLoop1308/PipePipeClient/pull/24
final int payloadReaderFlags = DefaultTsPayloadReaderFactory.FLAG_DETECT_ACCESS_UNITS;
return new HlsMediaSource.Factory(ytHlsCacheDataSourceFactory)
.setExtractorFactory(new DefaultHlsExtractorFactory(payloadReaderFlags, true));
}

public DashMediaSource.Factory getYoutubeDashMediaSourceFactory() {
Expand Down
Loading