Skip to content

Fix video playback when exiting popup to main screen#13437

Open
Y2kz wants to merge 3 commits intoTeamNewPipe:devfrom
Y2kz:fix/issue-6400-popup-video-switch-to-different-when-fullscreen
Open

Fix video playback when exiting popup to main screen#13437
Y2kz wants to merge 3 commits intoTeamNewPipe:devfrom
Y2kz:fix/issue-6400-popup-video-switch-to-different-when-fullscreen

Conversation

@Y2kz
Copy link
Copy Markdown

@Y2kz Y2kz commented Apr 19, 2026

What is it?

  • Bugfix (user facing)

Description of the changes in your PR

  • The fix makes transitions from the popup player to the main screen seamless
  • The popup video now plays in the attached view as expected . (Earlier, the video opened in the background was playing instead).

Before/After Screenshots/Screen Record

  • Before:
screen-20260419-134456-1776586469119.2.mp4

  • After:
screen-20260419-130907-1776584320954.2.mp4

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label Apr 19, 2026
@ShareASmile ShareASmile added bug Issue is related to a bug player Issues related to any player (main, popup and background) labels Apr 19, 2026
Copy link
Copy Markdown
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM. just a minor comment. A rebase is also needed to run the new test matrix.

this.forceFullscreen = force;
}

//return the URL of the stream currently handled by this fragment.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use a JDoc comment or remove the vomment.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I have rebased and removed the comment

@Y2kz Y2kz force-pushed the fix/issue-6400-popup-video-switch-to-different-when-fullscreen branch from 35385b9 to 7c071b7 Compare April 20, 2026 09:09
Y2kz added 3 commits April 21, 2026 14:46
Fix for the issue ( TeamNewPipe#6400 ) wrong video plays when exiting popup mode to fullscreen.
Split line into two address CI build error -VideoDetailFragment.java:1146: Line is longer than 100 characters (found 110). [LineLength]
Removed comment in commit
@Y2kz Y2kz force-pushed the fix/issue-6400-popup-video-switch-to-different-when-fullscreen branch from 7c071b7 to f29b465 Compare April 21, 2026 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue is related to a bug player Issues related to any player (main, popup and background) size/small PRs with less than 50 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants