Conversation
|
@theimpulson please checkout the new changes with the |
| .value("user_comment", comment) | ||
| .end() | ||
| .done() | ||
| } catch (e: Exception) { |
There was a problem hiding this comment.
| } catch (e: Exception) { | |
| } catch (exception: Exception) { |
Please don't use one word variable names
| activity?.let { | ||
| if (it.isTaskRoot) { | ||
| it.startActivity( | ||
| Intent(it, MainActivity::class.java).apply { |
There was a problem hiding this comment.
I am not sure but won't this keep looping back and forth in case of crash when ErrorActivity is launched by acra?
| containerColor = MaterialTheme.colorScheme.surface, | ||
| titleContentColor = MaterialTheme.colorScheme.onSurface, | ||
| textContentColor = MaterialTheme.colorScheme.onSurfaceVariant |
There was a problem hiding this comment.
Why are we specifying these colors manually?
| private const val ACTION_EMAIL = "EMAIL" | ||
| private const val ACTION_GITHUB = "GITHUB" |
There was a problem hiding this comment.
Please put variables before functions and classes similar to how we structure things in a class
Thank you, looks good to me other than some minor nitpicks and questions on places where I am unsure about the behavior. |
What is it?
Description of the changes in your PR
Converted ErrorActivity from Android Views to Jetpack Compose. The XML layout and menu are replaced by a Compose screen with all the same sections: error message, device info, stack trace details, user comment field, and report/share actions. The privacy policy dialog was also converted to Compose so it survives rotation and renders correctly with Material 3 theming. A shared BaseActivity was introduced to provide edge-to-edge display and Compose theme setup, serving as the foundation for future activity migrations.
Before/After Screenshots/Screen Record
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence