Close keyboard first when navigating back from search#13433
Open
utafrali wants to merge 1 commit intoTeamNewPipe:devfrom
Open
Close keyboard first when navigating back from search#13433utafrali wants to merge 1 commit intoTeamNewPipe:devfrom
utafrali wants to merge 1 commit intoTeamNewPipe:devfrom
Conversation
Member
Member
|
Also, your linked issue seems to have been closed as duplicate for #13431 which is what the PR I linked above is resolving. |
ShareASmile
added
the
template ignored
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About this PR
The back button in search was closing the suggestions panel even when the keyboard was open, which is annoying. Fixed it by checking if the keyboard is visible first and closing that instead. Extracted the keyboard visibility check into a new isKeyboardVisible() method on KeyboardUtil.
Checklist