Skip to content

[Refactor] Fix timestamp links in comments seeking in internal player#13415

Closed
Ecomont wants to merge 2 commits intoTeamNewPipe:refactorfrom
Ecomont:fix/comment-timestamp-seek
Closed

[Refactor] Fix timestamp links in comments seeking in internal player#13415
Ecomont wants to merge 2 commits intoTeamNewPipe:refactorfrom
Ecomont:fix/comment-timestamp-seek

Conversation

@Ecomont
Copy link
Copy Markdown

@Ecomont Ecomont commented Apr 13, 2026

What is it?

  • Bugfix (user facing)
  • Feature (user facing) ⚠️ Your PR must target the refactor branch
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Add timestamp click handling to DescriptionText in Compose.
  • Detect timestamp patterns in comment text and convert them into clickable timestamp links.
  • Pass an onTimestampClick callback from the comments UI down to the text component.
  • Make timestamp clicks in comments seek the currently opened video instead of opening an external browser or app.
  • Keep normal non-timestamp links handled as regular links.
  • Reuse the existing timestamp parsing logic instead of introducing a separate parser.

Before/After Screenshots/Screen Record

  • Before:
bugVideo.mp4
  • After:
afterVideo.mp4

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions Bot added the size/medium PRs with less than 250 changed lines label Apr 13, 2026
@Ecomont Ecomont closed this Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/medium PRs with less than 250 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant