Fix playback not working after player enters idle state#13390
Merged
TobiGr merged 1 commit intoTeamNewPipe:devfrom Apr 20, 2026
Merged
Fix playback not working after player enters idle state#13390TobiGr merged 1 commit intoTeamNewPipe:devfrom
TobiGr merged 1 commit intoTeamNewPipe:devfrom
Conversation
7 tasks
On some phones (e.g. Oppo and Oneplus) the video player enters the STATE_IDLE 10 minutes after being paused. This causes the play button to stop working. This happens because once a player has become idle, we need to call prepare() before playback can happen again. But after I added prepare(), it would just skip to the end of the video. So now I'm executing the same code that happens when ERROR_CODE_UNSPECIFIED is done. This causes playback to resume normally.
b3b36ba to
a719b89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
How I implemented the changes:
How to reproduce
If you have a Oneplus or Oppo phone then:
If your phone is different, you can simulate this by adding the following code to Player.java:
Before/After Screenshots/Screen Record
In the video below, I paused the video, then turned my screen off for 10 minutes. After that, pressing the play button does nothing.
playback_fail_after_idle.mp4
After my code changes, I did the same steps as before, but now the play button worked as expected.
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence