Skip to content

Fix NullPointerException in enqueue actions by using Application Context #13385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TobiGr merged 1 commit into from
Mar 29, 2026
Merged

Fix NullPointerException in enqueue actions by using Application Context #13385

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 21 additions & 15 deletions app/src/main/java/org/schabi/newpipe/info_list/dialog/StreamDialogDefaultEntry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import static org.schabi.newpipe.util.SparseItemUtil.fetchStreamInfoAndSaveToDatabase;
import static org.schabi.newpipe.util.SparseItemUtil.fetchUploaderUrlIfSparse;

import android.content.Context;
import android.net.Uri;

import androidx.annotation.NonNull;
Expand Down Expand Up @@ -52,28 +53,33 @@ public enum StreamDialogDefaultEntry {
/**
* Enqueues the stream automatically to the current PlayerType.
*/
ENQUEUE(R.string.enqueue_stream, (fragment, item) ->
fetchItemInfoIfSparse(fragment.requireContext(), item, singlePlayQueue ->
NavigationHelper.enqueueOnPlayer(fragment.getContext(), singlePlayQueue))
),
ENQUEUE(R.string.enqueue_stream, (fragment, item) -> {
final Context ctx = fragment.requireContext().getApplicationContext();
fetchItemInfoIfSparse(ctx, item, singlePlayQueue ->
NavigationHelper.enqueueOnPlayer(ctx, singlePlayQueue));
}),

/**
* Enqueues the stream automatically to the current PlayerType
* after the currently playing stream.
*/
ENQUEUE_NEXT(R.string.enqueue_next_stream, (fragment, item) ->
fetchItemInfoIfSparse(fragment.requireContext(), item, singlePlayQueue ->
NavigationHelper.enqueueNextOnPlayer(fragment.getContext(), singlePlayQueue))
),
ENQUEUE_NEXT(R.string.enqueue_next_stream, (fragment, item) -> {
final Context ctx = fragment.requireContext().getApplicationContext();
fetchItemInfoIfSparse(ctx, item, singlePlayQueue ->
NavigationHelper.enqueueNextOnPlayer(ctx, singlePlayQueue));
}),

START_HERE_ON_BACKGROUND(R.string.start_here_on_background, (fragment, item) ->
fetchItemInfoIfSparse(fragment.requireContext(), item, singlePlayQueue ->
NavigationHelper.playOnBackgroundPlayer(
fragment.getContext(), singlePlayQueue, true))),
START_HERE_ON_BACKGROUND(R.string.start_here_on_background, (fragment, item) -> {
final Context ctx = fragment.requireContext().getApplicationContext();
fetchItemInfoIfSparse(ctx, item, singlePlayQueue ->
NavigationHelper.playOnBackgroundPlayer(ctx, singlePlayQueue, true));
}),

START_HERE_ON_POPUP(R.string.start_here_on_popup, (fragment, item) ->
fetchItemInfoIfSparse(fragment.requireContext(), item, singlePlayQueue ->
NavigationHelper.playOnPopupPlayer(fragment.getContext(), singlePlayQueue, true))),
START_HERE_ON_POPUP(R.string.start_here_on_popup, (fragment, item) -> {
final Context ctx = fragment.requireContext().getApplicationContext();
fetchItemInfoIfSparse(ctx, item, singlePlayQueue ->
NavigationHelper.playOnPopupPlayer(ctx, singlePlayQueue, true));
}),

SET_AS_PLAYLIST_THUMBNAIL(R.string.set_as_playlist_thumbnail, (fragment, item) -> {
throw new UnsupportedOperationException("This needs to be implemented manually "
Expand Down
Loading