Skip to content

Add link to FAQ entry to "Sign in to confirm not a bot" exception message#13310

Merged
TobiGr merged 5 commits intoTeamNewPipe:devfrom
absurdlylongusername:add-issue-url-sign-in-not-bot-exception
Mar 8, 2026
Merged

Add link to FAQ entry to "Sign in to confirm not a bot" exception message#13310
TobiGr merged 5 commits intoTeamNewPipe:devfrom
absurdlylongusername:add-issue-url-sign-in-not-bot-exception

Conversation

@absurdlylongusername
Copy link
Copy Markdown
Member

@absurdlylongusername absurdlylongusername commented Mar 6, 2026

What is it?

  • Bugfix (user facing) (Idk which one to tick so I just pick this one :) )
  • Feature (user facing) ⚠️ Your PR must target the refactor branch
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Adds URL to #11139 to the SignInConfirmNotBotException error message that displays info about YouTube banning IP.

This is to make it clear to users that this is not a bug on NewPipe's side and thus they should not open a new issue about it.

  • Updated the sign in confirm not bot exception message in string resource
  • The URL is parameterised for translations; hardcoded in ErrorInfo.kt and passed in via string format
  • Refactoring ErrorMessage.getString to ErrorMessage.getText: it now uses getText and returns CharSequence instead of string in order to preserve text styling (i.e. URLs)
  • Added helper extension method for setting text of TextViews and making links clickable within them
  • Added extension method to do getText with format arguments

Before/After Screenshots/Screen Record

Error Panel (apologies for light mode flashbang I just used default emulator settings 🙏 )

Before After
Error Panel Before Error Panel After

Error Activity

Before After
Error Activity Before Error Activity After

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

To verify that this works, you can throw a SignInConfirmNotBotException in YouTubeStreamerExtractor.onFetchPage, or if you have VPN switch to a region that youtube has banned.

Then load a YT video and verify that the link in the error message is clickable.

Due diligence

@github-actions github-actions Bot added the size/medium PRs with less than 250 changed lines label Mar 6, 2026
@absurdlylongusername absurdlylongusername changed the title Add issue url for "Sign in to confirm not a bot" Youtube Error issue URL to the exception error message Add issue url to "Sign in to confirm not a bot" exception message Mar 6, 2026
@absurdlylongusername absurdlylongusername marked this pull request as draft March 6, 2026 11:59
@absurdlylongusername absurdlylongusername marked this pull request as ready for review March 6, 2026 12:33
Make error panel and error activity exception message URLs clickable via extension method

Change ErrorMessage.getString to getText and return CharSequence, and use getText with formatArgs to preserve styling (i.e. URLs)
@absurdlylongusername absurdlylongusername force-pushed the add-issue-url-sign-in-not-bot-exception branch from 9cda901 to e173bf4 Compare March 6, 2026 12:35
Comment thread app/src/main/res/values/strings.xml Outdated
Comment thread app/src/main/res/values/strings.xml Outdated
Copy link
Copy Markdown
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@TobiGr TobiGr enabled auto-merge March 8, 2026 17:56
@TobiGr TobiGr changed the title Add issue url to "Sign in to confirm not a bot" exception message Add link to FAQ entry to "Sign in to confirm not a bot" exception message Mar 8, 2026
@TobiGr TobiGr disabled auto-merge March 8, 2026 17:56
@TobiGr TobiGr enabled auto-merge March 8, 2026 17:56
@TobiGr TobiGr merged commit 05f09c9 into TeamNewPipe:dev Mar 8, 2026
5 of 6 checks passed
@TobiGr
Copy link
Copy Markdown
Contributor

TobiGr commented Mar 8, 2026

/backport release-0.28.4

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 8, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/medium PRs with less than 250 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants