Skip to content

Migrate MainFragment to ViewPager2#13240

Closed
ghost wants to merge 1 commit intodevfrom
unknown repository
Closed

Migrate MainFragment to ViewPager2#13240
ghost wants to merge 1 commit intodevfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Feb 12, 2026

What is it?

  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Delete workaround class
  • Migrate MainFragmet to ViewPager2
  1. I don't know if the bug which was workaround-ed is present. It should be solved by Viewpager2 but Idk
  2. It has much slower scroll speed and I don't know how to increase it

I know, refactor and etc. if you want to mention it just close this PR right away. Btw I at least got accustomed with logic of main page. Tbh I even expect you to say that and so I won't need to test that bug and finding way to increase scroll speed :)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions Bot added the size/large PRs with less than 750 changed lines label Feb 12, 2026
@absurdlylongusername
Copy link
Copy Markdown
Member

I know, refactor and etc. if you want to mention it just close this PR right away.

You can just do this on the refactor branch instead, no? x)

Instead of closing the PR

@ghost
Copy link
Copy Markdown
Author

ghost commented Feb 13, 2026

I know, refactor and etc. if you want to mention it just close this PR right away.

You can just do this on the refactor branch instead, no? x)

Refactor is for compose so it didn't have much sense to do this change at all because it is still a view based thing and current implementation works (kinda seamlessly). But I kinda wanted to ditch that big workaround class (mainly because the workaround has old style IntDef instead of enum and creates a full blown folder 😆) and was sucked in into the process...

@TobiGr
Copy link
Copy Markdown
Contributor

TobiGr commented Feb 13, 2026

I'd suggest to close this because reviewing and testing this PR takes too much time. And as you already mentioned we need to do work on this again with the switch to compose.

@ghost ghost closed this Feb 13, 2026
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/large PRs with less than 750 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants