Migrate MainFragment to ViewPager2#13240
Conversation
You can just do this on the refactor branch instead, no? x) Instead of closing the PR |
Refactor is for compose so it didn't have much sense to do this change at all because it is still a view based thing and current implementation works (kinda seamlessly). But I kinda wanted to ditch that big workaround class (mainly because the workaround has old style IntDef instead of enum and creates a full blown folder 😆) and was sucked in into the process... |
|
I'd suggest to close this because reviewing and testing this PR takes too much time. And as you already mentioned we need to do work on this again with the switch to compose. |
What is it?
Description of the changes in your PR
I know, refactor and etc. if you want to mention it just close this PR right away. Btw I at least got accustomed with logic of main page. Tbh I even expect you to say that and so I won't need to test that bug and finding way to increase scroll speed :)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence