Show toast "checking for update..." every time user starts manual check#13229
Conversation
When user toggles auto updates in settings it will firstly show "check for update..." toast as like if user presses to button of manual check. It adds consistency and allows to reuse manual check in other places of the app
ghost
marked this pull request as ready for review
|
@ShareASmile one more question did you approve this PR when it was marked as ready for review immediately or in the moment you added label? |
|
No, I didn't approve it, only added labels. Otherwise github might have shown it in the events of this PR. |
I meant CI approval, sorry for disambiguation |
|
@TobiGr you did approve CI initially right? |
|
Why is the current implementation an issue? Also, please don't put UI related code outside of UI logic such as background workers and services. |
ghost
mentioned this pull request
Very fair but current implementation already creates toast from there so I though, why not. Though I already have some ideas how to do it better... Much better |
|
Read docs about WorkManager so I close it as there is a way to do it better |
ghost
closed this
2 participants
What is it?
refactorbranchBefore/After
Before:
bad.mp4
After:
good.mp4
Description of the changes in your PR
Show toast "checking for update..." every time user starts manual check
When user toggles auto updates in settings it will firstly show "check for update..." toast as like if user presses to button of manual check. It adds consistency and allows to reuse manual check in other places of the app
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence