Skip to content

Run checkstyle for extractor when it is built from source #13158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost wants to merge 2 commits into from
Closed

Run checkstyle for extractor when it is built from source #13158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a4ef03
settings.gradle.kts: apply changes applied by android-studio
Jan 31, 2026
b3ecf06
Run checkstyle for extractor when it is built from source
Jan 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,6 @@ ksp {
arg("room.schemaLocation", "$projectDir/schemas")
}


// Custom dependency configuration for ktlint
val ktlint by configurations.creating

Expand Down Expand Up @@ -164,6 +163,11 @@ tasks.register<Checkstyle>("runCheckstyle") {
xml.required = true
html.required = true
}

// run checkstyle for extractor when it is built from source
if (gradle.extra.has("extractorIncluded")) {
dependsOn(gradle.includedBuild("NewPipeExtractor").task(":extractor:checkstyleMain"))
}
}

val outputDir = project.layout.buildDirectory.dir("reports/ktlint/")
Expand Down
7 changes: 4 additions & 3 deletions settings.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,16 @@ dependencyResolutionManagement {
maven(url = "https://repo.clojars.org")
}
}
include (":app")
include(":app")

// Use a local copy of NewPipe Extractor by uncommenting the lines below.
// We assume, that NewPipe and NewPipe Extractor have the same parent directory.
// If this is not the case, please change the path in includeBuild().

//includeBuild("../NewPipeExtractor") {
// includeBuild("../NewPipeExtractor") {
// dependencySubstitution {
// substitute(module("com.github.TeamNewPipe:NewPipeExtractor"))
// .using(project(":extractor"))
// }
//}
// }
// gradle.extra["extractorIncluded"] = true