Merged
Conversation
... Crash in lists (ViewHolder views not attached) in StatisticsPlaylistFragment Co-Authored-By: j-haldane <200528955+j-haldane@users.noreply.github.com>
Co-Authored-By: j-haldane <200528955+j-haldane@users.noreply.github.com>
…l-list-header-fix-by-j-haldane
The bug is caused by a wanted but forgotten inconsistency in the database. A stream can be listed in the watch history (StreamHistoryEntity) while having no corresponding playback state (StreamStateEntity) containing the matching playback position. This is caused by the fact that NewPipe does not consider a watch time of less than five seconds to be worthy to be put into the StreamStateEntity because the video was most likely played by error. Those videos are, however, counted and stored in the watch history.
Playlists can also contain audio-only items. Therefore, the term "stream" is used.
This partially reverts commit 92a07a3, which was needed to fix ghost notifications. There I broke the "cycle" causing the useless notifications to popup in 2 different places (see points 3 and 4 of the commit description). However, breaking the cycle in point 4 ("`PlayerHolder::tryBindIfNeeded()` is now used to passively try to bind, instead of `PlayerHolder::startService()`" was not correct, for the following reason. I assumed that `ACTION_PLAYER_STARTED` was used for notifying that the player was instantiated anew, while it actually is used to notify that something is now ready for use: it could be the player, but it could also just be that the bottom sheet view was just added and thus the VideoDetailFragment needs to start the player. Therefore, when handling `ACTION_PLAYER_STARTED` it is correct to start the player service and not just try to bind to it. The other point in which I broke the cycle (point 3) should still prevent ghost notifications, although I could not test.
…gment-flickers
…at/similar-youtube-client-screen-rotation
This is a hacky solution, a better one should be investigated and used.
As both subtitles and video tracks are disabled in this method, the goal of this rename is to highlight disabling/enabled subtitles.
This allows disabling these track types when stream info has been not loaded while the ExoPlayer instance is. It is now possible to do so with the background player, in order to disable fetching video and text tracks for manifest sources, especially used for livestreams. Also set the recovery first before reloading play queue manager in the useVideoAndSubtitles method of the Player class.
This reduces data usage for manifest sources with demuxed audio and video, such as livestreams, for non-HLS sources only due to an ExoPlayer bug.
…d-fetch-bg-audio-only
Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Latvian) Currently translated at 20.6% (18 of 87 strings) Translated using Weblate (Latvian) Currently translated at 96.9% (741 of 764 strings) Translated using Weblate (Vietnamese) Currently translated at 99.6% (761 of 764 strings) Translated using Weblate (Basque) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Chinese (Simplified Han script)) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Thai) Currently translated at 37.3% (285 of 764 strings) Translated using Weblate (Basque) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Basque) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (French) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Basque) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Turkish) Currently translated at 33.3% (29 of 87 strings) Translated using Weblate (Spanish) Currently translated at 74.7% (65 of 87 strings) Translated using Weblate (Basque) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Lombard) Currently translated at 4.9% (38 of 764 strings) Translated using Weblate (Lombard) Currently translated at 2.2% (2 of 87 strings) Translated using Weblate (Basque) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Basque) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Basque) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Basque) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Basque) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Arabic) Currently translated at 97.7% (85 of 87 strings) Translated using Weblate (Basque) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Turkish) Currently translated at 33.3% (29 of 87 strings) Translated using Weblate (Basque) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Basque) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Basque) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Latvian) Currently translated at 95.8% (732 of 764 strings) Translated using Weblate (Basque) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Latvian) Currently translated at 95.8% (732 of 764 strings) Translated using Weblate (Latvian) Currently translated at 95.2% (728 of 764 strings) Translated using Weblate (Latvian) Currently translated at 95.2% (728 of 764 strings) Translated using Weblate (Latvian) Currently translated at 95.6% (731 of 764 strings) Translated using Weblate (Basque) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Basque) Currently translated at 100.0% (87 of 87 strings) Translated using Weblate (Basque) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Spanish) Currently translated at 74.7% (65 of 87 strings) Added translation using Weblate (Yiddish) Co-authored-by: AudricV <AudricV@users.noreply.hosted.weblate.org> Co-authored-by: CJ Montero <cristlad@proton.me> Co-authored-by: Erenay <erenaydev@proton.me> Co-authored-by: Hasan Kara <hasanbeytullahkara@gmail.com> Co-authored-by: Hosted Weblate <hosted@weblate.org> Co-authored-by: Igi 5216 <dr.siantonov@gmail.com> Co-authored-by: Mohammed al-Qubati <mhraqeeb@gmail.com> Co-authored-by: Nicolás Pérez <ccnicolasperez@gmail.com> Co-authored-by: TXRdev Archive <lckphanaf9999@gmail.com> Co-authored-by: Thadah D. Denyse <thadahdenyse@protonmail.com> Co-authored-by: ThaiWithNoBraincell <altofskgd@gmail.com> Co-authored-by: What's news <fishelschonfeld@gmail.com> Co-authored-by: ℂ𝕠𝕠𝕠𝕝 (𝕘𝕚𝕥𝕙𝕦𝕓.𝕔𝕠𝕞/ℂ𝕠𝕠𝕠𝕝) <coool@mail.lv> Co-authored-by: 大王叫我来巡山 <hamburger2048@users.noreply.hosted.weblate.org> Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/ar/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/es/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/eu/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/lmo/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/lv/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/tr/ Translation: NewPipe/Metadata
Currently translated at 71.5% (547 of 764 strings) Translated using Weblate (Somali) Currently translated at 71.5% (547 of 764 strings) Translated using Weblate (Danish) Currently translated at 98.5% (753 of 764 strings) Translated using Weblate (Danish) Currently translated at 98.5% (753 of 764 strings) Translated using Weblate (Kurdish (Central)) Currently translated at 80.4% (615 of 764 strings) Translated using Weblate (Dutch (Belgium)) Currently translated at 73.5% (562 of 764 strings) Translated using Weblate (Dutch (Belgium)) Currently translated at 73.5% (562 of 764 strings) Translated using Weblate (Hungarian) Currently translated at 99.7% (762 of 764 strings) Translated using Weblate (Hungarian) Currently translated at 99.7% (762 of 764 strings) Translated using Weblate (Georgian) Currently translated at 92.5% (707 of 764 strings) Translated using Weblate (Kurdish) Currently translated at 60.9% (466 of 764 strings) Translated using Weblate (Catalan) Currently translated at 96.0% (734 of 764 strings) Translated using Weblate (Catalan) Currently translated at 96.0% (734 of 764 strings) Translated using Weblate (Greek) Currently translated at 99.7% (762 of 764 strings) Translated using Weblate (French) Currently translated at 99.7% (762 of 764 strings) Translated using Weblate (French) Currently translated at 99.7% (762 of 764 strings) Translated using Weblate (Japanese) Currently translated at 95.5% (730 of 764 strings) Translated using Weblate (Belarusian) Currently translated at 98.8% (755 of 764 strings) Translated using Weblate (Vietnamese) Currently translated at 99.3% (759 of 764 strings) Translated using Weblate (Odia) Currently translated at 95.2% (728 of 764 strings) Translated using Weblate (Russian) Currently translated at 99.7% (762 of 764 strings) Translated using Weblate (Russian) Currently translated at 99.7% (762 of 764 strings) Translated using Weblate (Korean) Currently translated at 98.4% (752 of 764 strings) Translated using Weblate (Korean) Currently translated at 98.4% (752 of 764 strings) Translated using Weblate (Interlingua) Currently translated at 31.1% (238 of 764 strings) Translated using Weblate (Interlingua) Currently translated at 31.1% (238 of 764 strings) Translated using Weblate (Indonesian) Currently translated at 99.7% (762 of 764 strings) Translated using Weblate (Indonesian) Currently translated at 99.7% (762 of 764 strings) Translated using Weblate (Tamazight (Central Atlas)) Currently translated at 18.5% (142 of 764 strings) Translated using Weblate (Portuguese (Brazil)) Currently translated at 99.7% (762 of 764 strings) Translated using Weblate (Turkish) Currently translated at 99.7% (762 of 764 strings) Translated using Weblate (Turkish) Currently translated at 99.7% (762 of 764 strings) Translated using Weblate (Portuguese (Portugal)) Currently translated at 99.7% (762 of 764 strings) Translated using Weblate (Portuguese (Portugal)) Currently translated at 99.7% (762 of 764 strings) Translated using Weblate (Arabic (Libya)) Currently translated at 93.4% (714 of 764 strings) Translated using Weblate (Slovak) Currently translated at 99.7% (762 of 764 strings) Translated using Weblate (Azerbaijani) Currently translated at 99.7% (762 of 764 strings) Translated using Weblate (Lithuanian) Currently translated at 98.9% (756 of 764 strings) Translated using Weblate (Lithuanian) Currently translated at 98.9% (756 of 764 strings) Translated using Weblate (Portuguese) Currently translated at 99.7% (762 of 764 strings) Translated using Weblate (Portuguese) Currently translated at 99.7% (762 of 764 strings) Translated using Weblate (Hindi) Currently translated at 99.7% (762 of 764 strings) Translated using Weblate (Hindi) Currently translated at 99.7% (762 of 764 strings) Translated using Weblate (Czech) Currently translated at 99.7% (762 of 764 strings) Translated using Weblate (Asturian) Currently translated at 60.6% (463 of 764 strings) Translated using Weblate (Asturian) Currently translated at 60.6% (463 of 764 strings) Translated using Weblate (Hebrew) Currently translated at 99.7% (762 of 764 strings) Translated using Weblate (Hebrew) Currently translated at 99.7% (762 of 764 strings) Translated using Weblate (Sardinian) Currently translated at 97.9% (748 of 764 strings) Translated using Weblate (Sardinian) Currently translated at 97.9% (748 of 764 strings) Translated using Weblate (Chinese (Traditional Han script, Hong Kong)) Currently translated at 95.1% (727 of 764 strings) Translated using Weblate (Albanian) Currently translated at 76.3% (583 of 764 strings) Translated using Weblate (Albanian) Currently translated at 76.3% (583 of 764 strings) Translated using Weblate (Nepali) Currently translated at 56.2% (430 of 764 strings) Translated using Weblate (Nepali) Currently translated at 56.2% (430 of 764 strings) Translated using Weblate (Finnish) Currently translated at 94.2% (720 of 764 strings) Translated using Weblate (Finnish) Currently translated at 94.2% (720 of 764 strings) Translated using Weblate (Uzbek (Latin script)) Currently translated at 59.2% (453 of 764 strings) Translated using Weblate (Uzbek (Latin script)) Currently translated at 59.2% (453 of 764 strings) Translated using Weblate (Punjabi) Currently translated at 99.7% (762 of 764 strings) Translated using Weblate (Kurdish (Northern)) Currently translated at 62.5% (478 of 764 strings) Translated using Weblate (Kurdish (Northern)) Currently translated at 62.5% (478 of 764 strings) Translated using Weblate (Icelandic) Currently translated at 98.1% (750 of 764 strings) Translated using Weblate (N’Ko) Currently translated at 85.7% (655 of 764 strings) Translated using Weblate (Croatian) Currently translated at 99.7% (762 of 764 strings) Translated using Weblate (Serbian) Currently translated at 99.7% (762 of 764 strings) Translated using Weblate (Serbian) Currently translated at 99.7% (762 of 764 strings) Translated using Weblate (Spanish) Currently translated at 99.7% (762 of 764 strings) Translated using Weblate (Spanish) Currently translated at 99.7% (762 of 764 strings) Translated using Weblate (Ukrainian) Currently translated at 99.7% (762 of 764 strings) Translated using Weblate (Ukrainian) Currently translated at 99.7% (762 of 764 strings) Translated using Weblate (Bengali) Currently translated at 74.2% (567 of 764 strings) Translated using Weblate (German) Currently translated at 99.7% (762 of 764 strings) Translated using Weblate (German) Currently translated at 99.7% (762 of 764 strings) Translated using Weblate (Romanian) Currently translated at 97.6% (746 of 764 strings) Translated using Weblate (Romanian) Currently translated at 97.6% (746 of 764 strings) Translated using Weblate (Chinese (Simplified Han script)) Currently translated at 99.7% (762 of 764 strings) Translated using Weblate (ryu (generated) (ryu)) Currently translated at 95.2% (728 of 764 strings) Translated using Weblate (Arabic) Currently translated at 99.7% (762 of 764 strings) Translated using Weblate (Galician) Currently translated at 95.2% (728 of 764 strings) Translated using Weblate (Galician) Currently translated at 95.2% (728 of 764 strings) Translated using Weblate (Italian) Currently translated at 99.7% (762 of 764 strings) Translated using Weblate (Italian) Currently translated at 99.7% (762 of 764 strings) Translated using Weblate (Dutch) Currently translated at 99.7% (762 of 764 strings) Translated using Weblate (Dutch) Currently translated at 99.7% (762 of 764 strings) Translated using Weblate (Estonian) Currently translated at 99.7% (762 of 764 strings) Translated using Weblate (Estonian) Currently translated at 99.7% (762 of 764 strings) Translated using Weblate (Bulgarian) Currently translated at 99.7% (762 of 764 strings) Translated using Weblate (Bulgarian) Currently translated at 99.7% (762 of 764 strings) Translated using Weblate (Malayalam) Currently translated at 73.0% (558 of 764 strings) Translated using Weblate (Malayalam) Currently translated at 73.0% (558 of 764 strings) Translated using Weblate (Swedish) Currently translated at 99.7% (762 of 764 strings) Translated using Weblate (Swedish) Currently translated at 99.7% (762 of 764 strings) Translated using Weblate (Persian) Currently translated at 95.6% (731 of 764 strings) Translated using Weblate (Norwegian Bokmål) Currently translated at 89.9% (687 of 764 strings) Translated using Weblate (Norwegian Bokmål) Currently translated at 89.9% (687 of 764 strings) Translated using Weblate (Polish) Currently translated at 99.7% (762 of 764 strings) Co-authored-by: 2-Seol <2Seol.0117@gmail.com> Co-authored-by: Agnieszka C <aga_04@o2.pl> Co-authored-by: Ajeje Brazorf <lmelonimamo@yahoo.it> Co-authored-by: Allan Nordhøy <epost@anotheragency.no> Co-authored-by: Andreas Westrell <andreas.westrell@gmail.com> Co-authored-by: Anonymous <noreply@weblate.org> Co-authored-by: Anxhelo Lushka <github@lushka.al> Co-authored-by: AudricV <AudricV@users.noreply.hosted.weblate.org> Co-authored-by: Aurelian Ciocîltan <aurelianciociltan@gmail.com> Co-authored-by: Bakary Kaba <mbkaba@live.fr> Co-authored-by: Balázs Meskó <meskobalazs@mailbox.org> Co-authored-by: ButterflyOfFire <boffire@users.noreply.hosted.weblate.org> Co-authored-by: D D <keptawesome@gmail.com> Co-authored-by: David Rebolo Magariños <davidre345@hotmail.com> Co-authored-by: Deleted User <jsdelvani@users.noreply.hosted.weblate.org> Co-authored-by: Deleted User <noreply+10474@weblate.org> Co-authored-by: Deleted User <noreply+19964@weblate.org> Co-authored-by: Dormin <nkzo3d+1uozh1scczh8c@sharklasers.com> Co-authored-by: Emin Tufan Çetin <etcetin@gmail.com> Co-authored-by: Enol P. <enolp@softastur.org> Co-authored-by: Femini <nizamismidov4@gmail.com> Co-authored-by: Fjuro <fjuro@alius.cz> Co-authored-by: Francesco Saltori <francescosaltori@gmail.com> Co-authored-by: GET100PERCENT <eraofphysics@yahoo.com> Co-authored-by: Guillem <guillemglez@gmail.com> Co-authored-by: Hakim Oubouali <hakim.oubouali.skr@gmail.com> Co-authored-by: Hoseok Seo <ddinghoya@gmail.com> Co-authored-by: Igor Nedoboy <i.nedoboy@mail.ru> Co-authored-by: Ishwor Ghimire <ghimire.esor09@gmail.com> Co-authored-by: Kiss Attila <gaxeco4855@pro5g.com> Co-authored-by: Ldm Public <ldmpub@gmail.com> Co-authored-by: MS-PC <MSPCtranslator@gmail.com> Co-authored-by: Marian Hanzel <marulinko@gmail.com> Co-authored-by: Mathias Hamza Vedsted-Mirza <mathiashamzamirza@outlook.com> Co-authored-by: Mickaël Binos <mickaelbinos@outlook.com> Co-authored-by: Milo Ivir <mail@milotype.de> Co-authored-by: Mukhamadjonov <abdukodir.9507@gmail.com> Co-authored-by: NEXI <nexiphotographer@gmail.com> Co-authored-by: Nadir Nour <dudethatwascool2@gmail.com> Co-authored-by: Nikoloz <nukushatugushi@gmail.com> Co-authored-by: Olivia Ng <uloo592@gmail.com> Co-authored-by: Oymate <dhruboadittya96@gmail.com> Co-authored-by: Philip Goto <philip.goto@gmail.com> Co-authored-by: Priit Jõerüüt <jrthwlate@users.noreply.hosted.weblate.org> Co-authored-by: SecularSteve <fairfull.playing@gmail.com> Co-authored-by: ShareASmile <ShareASmile@users.noreply.hosted.weblate.org> Co-authored-by: Sveinn í Felli <sv1@fellsnet.is> Co-authored-by: Sérgio Marques <smarquespt@gmail.com> Co-authored-by: Theophine Savio Theodore <theophinetheodore@gmail.com> Co-authored-by: Ville Rantanen <v.r@iki.fi> Co-authored-by: Yaron Shahrabani <sh.yaron@gmail.com> Co-authored-by: cat <catsnote@proton.me> Co-authored-by: cehnemdark <cehennem1001@gmail.com> Co-authored-by: gymka <gymka@archlinux.lt> Co-authored-by: nautilusx <translate@disroot.org> Co-authored-by: ngocanhtve <ngocanh.tve@gmail.com> Co-authored-by: winqooq <winqooq@gmail.com> Co-authored-by: zmni <zmni@outlook.com> Co-authored-by: Макар Разин <makarrazin14@gmail.com> Co-authored-by: Слободан Симић(Slobodan Simić) <slsimic@gmail.com>
# Conflicts: # app/src/main/java/org/schabi/newpipe/error/ErrorInfo.kt # app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.java # app/src/main/java/org/schabi/newpipe/player/Player.java # app/src/main/res/values-eu/strings.xml # gradle/libs.versions.toml
ShareASmile
added
code quality
Contributor
|
thanks, but it does not compile. Can you check this and also ensure that the parts effected by the merge still work as expected? |
Stypox
approved these changes
Feb 2, 2026
Member
Stypox
left a comment
Stypox
left a comment
There was a problem hiding this comment.
Thanks! I pushed two commits to fix Android tests related to error classification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
refactorbranchDescription of the changes in your PR
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence