Misc player loop/stream refactors#13135
Misc player loop/stream refactors#13135absurdlylongusername merged 2 commits intodevfrom unknown repository
Conversation
| int before = 0; | ||
| int after = 0; | ||
|
|
||
| final List<PlayQueueItem> streams = playQueue.getStreams(); | ||
| final int nStreams = streams.size(); | ||
|
|
||
| for (int i = 0; i < nStreams; i++) { | ||
| if (i < currentStream) { | ||
| before += streams.get(i).getDuration(); | ||
| } else { | ||
| after += streams.get(i).getDuration(); | ||
| } | ||
| } | ||
| final long before = streams.subList(0, currentStream).stream() | ||
| .collect(Collectors.summingLong(PlayQueueItem::getDuration)) * 1000; | ||
|
|
||
| before *= 1000; | ||
| after *= 1000; | ||
| final long after = streams.subList(currentStream, streams.size()).stream() | ||
| .collect(Collectors.summingLong(PlayQueueItem::getDuration)) * 1000; |
There was a problem hiding this comment.
@absurdlylongusername this part was getting messy because before and after were expected to be int (consumed later as int but PlayQeueItem stored longs). That is why I asked about this strange mix of ints and longs...
ShareASmile
added
the
code quality
ghost
force-pushed
the
player_loop_refactor
branch
from
e93c90e to
5ab024e
Compare
Duration data in the player code incosnistently typed. Half code uses ints and half uses longs. Recieve longs in this function to allow both halfs of player code just use the function without nasty long to int downcasting warnings/errors in code
ghost
force-pushed
the
player_loop_refactor
branch
from
5ab024e to
3a0a3a4
Compare
|
Looks good to me, but I think all refactors should come with tests, otherwise we have absolutely no guarantee on functionality apart from just eyeballing the code. @dustdfg Are you able to add tests for the refactored code? |
Yeah, I think |
I don't think so anymore, I've failed on adding test for much simpler thing with much less dependencies and mocking |
|
@dustdfg Okay. If I haven't added the tests myself to this PR within 48hrs, then I will approve and merge. |
|
Changed my mind; it's more efficient to merge this and add tests in a later PR |
3 participants
What is it?
Description of the changes in your PR
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence