Skip to content

TabsJsonHelper refactor#13131

Merged
theimpulson merged 1 commit intodevfrom
unknown repository
Feb 8, 2026
Merged

TabsJsonHelper refactor#13131
theimpulson merged 1 commit intodevfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Jan 27, 2026

What is it?

  • Codebase improvement (dev facing)

Description of the changes in your PR

  • Utilize java streams
  • Make one parameter non null

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions Bot added the size/small PRs with less than 50 changed lines label Jan 27, 2026
@ghost ghost force-pushed the tabs_json_helper_refactor branch from 1d663d3 to 94268b8 Compare January 28, 2026 09:50
@ShareASmile ShareASmile added the code quality Improvements to the codebase to improve the code quality label Jan 29, 2026
@ghost ghost force-pushed the tabs_json_helper_refactor branch from 94268b8 to c7f009f Compare January 29, 2026 17:25
Comment thread app/src/main/java/org/schabi/newpipe/settings/tabs/TabsManager.java Outdated
Comment thread app/src/main/java/org/schabi/newpipe/settings/tabs/TabsManager.java Outdated
@ghost ghost force-pushed the tabs_json_helper_refactor branch from c7f009f to 07fe1e7 Compare February 2, 2026 21:59
Copy link
Copy Markdown
Member

@theimpulson theimpulson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@theimpulson theimpulson merged commit 020dbdc into TeamNewPipe:dev Feb 8, 2026
4 of 5 checks passed
@ghost ghost deleted the tabs_json_helper_refactor branch February 8, 2026 15:54
@TobiGr TobiGr mentioned this pull request Feb 28, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code quality Improvements to the codebase to improve the code quality size/small PRs with less than 50 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants