Skip to content

Fix bug of search history randomly not saved #13061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost wants to merge 1 commit into from
Closed

Fix bug of search history randomly not saved #13061

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions app/src/main/java/org/schabi/newpipe/fragments/list/search/SearchFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -865,14 +865,15 @@ private void search(@NonNull final String theSearchString,
hideKeyboardSearch();

// store search query if search history is enabled
disposables.add(historyRecordManager.onSearched(serviceId, theSearchString)

historyRecordManager.onSearched(serviceId, theSearchString)
.observeOn(AndroidSchedulers.mainThread())
Copy link
Copy Markdown
Author

@ghost ghost Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I should change it to shedulers io?

.subscribe(
ignored -> {
},
throwable -> showSnackBarError(new ErrorInfo(throwable, UserAction.SEARCHED,
Copy link
Copy Markdown
Author

@ghost ghost Jan 14, 2026 •
edited by ghost
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am still not sure it is safe because of call to showSnackBarError. The same thing is with delete history item operations in the file...

Please help to answer following questions:

  1. Is current approach of this PR safe?
  2. If not safe maybe I should create separate composite disposable specifically for db these db related tasks?
    2.1. ...And then rename disposables variable as would be used for only one purpose a bit above this code (checking if search is url which can be opened in newpipe directly...)

I am almost sure 2 + 2.1 is the best way to go but Idk

theSearchString, serviceId))
));
);

// load search results
suggestionPublisher.onNext(theSearchString);
Expand Down