Bump minimum SDK version to API 23#13056
Merged
theimpulson merged 2 commits intoTeamNewPipe:refactorfrom Jan 21, 2026
Merged
Conversation
- Updated the `minSdk` in `app/build.gradle.kts`. - Adjusted the api-level for the test-android min sdk CI workflow in `.github/workflows/ci.yml`. - Simplified the `getOsString()` method in `ErrorActivity.java` by removing the conditional check for `Build.VERSION_CODES.M`, as API 23 is now the minimum.
ghost
reviewed
Jan 13, 2026
|
NewPipe is the most useful app on old devices. |
Member
|
@ale5000-git Basically Google is a cursed company that deprecates stuff and if we want to not be stuck on old libraries and be able to use newer features and stuff, then we need to increase minSdk otherwise development will be a lot harder for devs and available functionality will be limited. |
theimpulson
requested changes
Jan 18, 2026
Member
theimpulson
left a comment
theimpulson
left a comment
There was a problem hiding this comment.
Please remove all checks for Build.VERSION_CODES.M
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
theimpulson
approved these changes
Jan 19, 2026
Member
|
Thank you |
ShareASmile
added
code quality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
refactorbranchDescription of the changes in your PR
minSdkinapp/build.gradle.kts..github/workflows/ci.yml.getOsString()method inErrorActivity.javaby removing the conditional check forBuild.VERSION_CODES.M, as API 23 is now the minimum.Before/After Screenshots/Screen Record
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence