Skip to content

Convert a bunch of files to kotlin#13026

Merged
theimpulson merged 9 commits intodevfrom
unknown repository
Feb 10, 2026
Merged

Convert a bunch of files to kotlin#13026
theimpulson merged 9 commits intodevfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Jan 9, 2026

What is it?

  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Convert a bunch of files to kotlin

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions Bot added the size/giant PRs with more than 750 changed lines label Jan 9, 2026
@ghost ghost force-pushed the kotlin_merged2 branch 4 times, most recently from d7d02f7 to a549118 Compare January 9, 2026 22:15
@theimpulson
Copy link
Copy Markdown
Member

theimpulson commented Jan 11, 2026

No need to convert View related files to Kotlin as they will be deleted later with compose migration.

theimpulson
theimpulson requested changes Jan 11, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@theimpulson theimpulson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General feedback that seems to apply to the most of the converted code.

Comment thread app/src/main/java/org/schabi/newpipe/util/PeertubeHelper.kt Outdated
Comment thread app/src/main/java/org/schabi/newpipe/util/ServiceHelper.kt Outdated
Comment thread app/src/main/java/org/schabi/newpipe/util/ServiceHelper.kt Outdated
@theimpulson
Copy link
Copy Markdown
Member

theimpulson commented Jan 11, 2026

I suggest marking the PR as draft when it is still WIP. Once ready for review, please avoid doing changes unless asked or required to fix or improve existing code in the PR.

@ghost
Copy link
Copy Markdown
Author

ghost commented Jan 11, 2026 •
edited by ghost
Loading

No need to convert View related files to Kotlin as they will be deleted later with compose migration.

  1. As a user I was waiting for refactor to come for so long time that I don't believe in it...
  2. Kotlin is better
  3. +/-Ok

ghost
ghost commented Jan 11, 2026
View reviewed changes
Comment thread app/src/main/java/org/schabi/newpipe/local/subscription/ImportConfirmationDialog.kt Outdated
@HatakeKakashri
Copy link
Copy Markdown
Contributor

HatakeKakashri commented Jan 11, 2026

No need to convert View related files to Kotlin as they will be deleted later with compose migration.

  1. As a user I was waiting for refactor to come for so long time that I don't believe in it...

Seems fair. Might as well convert to Compose in the same PR if you are comfortable with it.

@ghost
Copy link
Copy Markdown
Author

ghost commented Jan 11, 2026

No need to convert View related files to Kotlin as they will be deleted later with compose migration.

  1. As a user I was waiting for refactor to come for so long time that I don't believe in it...

Seems fair. Might as well convert to Compose in the same PR if you are comfortable with it.

It would target another branch then

@ghost ghost force-pushed the kotlin_merged2 branch from a549118 to 301d391 Compare January 11, 2026 10:35
@ghost ghost requested a review from theimpulson January 11, 2026 11:57
@ghost ghost force-pushed the kotlin_merged2 branch from 301d391 to 906592b Compare January 11, 2026 13:58
@theimpulson theimpulson removed their request for review January 11, 2026 14:54
@ghost ghost force-pushed the kotlin_merged2 branch from 906592b to 6290be4 Compare February 10, 2026 07:28
@theimpulson
Copy link
Copy Markdown
Member

theimpulson commented Feb 10, 2026

@dustdfg please fix the ktlint failures, thanks!

@ghost ghost force-pushed the kotlin_merged2 branch from 6290be4 to c6fc94e Compare February 10, 2026 08:09
@theimpulson
Minor improvements
224a5d0 
- Use early return in case of nulls
- Use better variable names
- Remove non-required newlines, imports and add missing ones

Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
theimpulson
theimpulson approved these changes Feb 10, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@theimpulson theimpulson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@theimpulson theimpulson merged commit e6e0be7 into TeamNewPipe:dev Feb 10, 2026
5 checks passed
@ShareASmile ShareASmile added the code quality Improvements to the codebase to improve the code quality label Feb 10, 2026
@TobiGr TobiGr mentioned this pull request Feb 28, 2026
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

code quality Improvements to the codebase to improve the code quality size/giant PRs with more than 750 changed lines

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@theimpulson @HatakeKakashri @ShareASmile