Allow dragging boorkmarked playlist in both directions#13008
Allow dragging boorkmarked playlist in both directions#13008TobiGr merged 1 commit intorelease-0-28.1from unknown repository
Conversation
|
thank you, lgtm, but please change the base branch to the release branch for 0.28.1 |
Ctrl+C/Ctrl+V from newpipe/local/playlist/LocalPlaylistFragment
a1fb7b7 to
9998d99
Compare
Can you please provide something like lambda for me that allows to understand which branch should be targeted? |
|
I saw that the linked issue is in the 0.28.x project. I somehow assumed that the subversion was set to 0.28.1, which was initially true, but I moved in to 0.28.2 a few days ago. Since dev has already non-fix changes compered to when the release process was initiated, fixes for the relea should target the release branch. And that's where I messed up. You did everything correctly and targeted dev. But this is a simple fix which can be included in the new release easily. Code looks good, test runners have problems to run the build |
|
|
What is it?
Description of the changes in your PR
Allow dragging boorkmarked playlist in both directions. Its code is Ctrl+C/Ctrl+V from
newpipe/local/playlist/LocalPlaylistFragment. All necessary infrastructure was already present but just not used¯\_(ツ)_/¯Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence