Skip to content

Utilize var syntax for some local variables in some java files#12988

Closed
ghost wants to merge 1 commit intodevfrom
unknown repository
Closed

Utilize var syntax for some local variables in some java files#12988
ghost wants to merge 1 commit intodevfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Jan 1, 2026

What is it?

  • Codebase improvement (dev facing)

Description of the changes in your PR

  • Utilize var syntax for some local variables in some java files
  • In most places it is conservative

Kotlin isn't going to come for most of files (especially big) in near time but java also has var so it is a small step toward clarity of kotlin.

I expect you will say it is too stupid and I will even agree so just close this PR right away if you feel so. I won't be pouting :3

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions Bot added the size/large PRs with less than 750 changed lines label Jan 1, 2026
@theimpulson
Copy link
Copy Markdown
Member

Hi, thanks for the PR but sadly this doesn't seems particularly useful since we will eventually move to Kotlin this year. I will be closing this as won't do.

@theimpulson theimpulson closed this Jan 2, 2026
@ghost ghost deleted the java_var_refactor branch January 2, 2026 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/large PRs with less than 750 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant