Skip to content

Refactor ExportPlaylist to use more idiomatic kotlin code#12981

Merged
theimpulson merged 1 commit intodevfrom
unknown repository
Jan 1, 2026
Merged

Refactor ExportPlaylist to use more idiomatic kotlin code#12981
theimpulson merged 1 commit intodevfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Dec 31, 2025

What is it?

  • Codebase improvement (dev facing)

Description of the changes in your PR

  • Refactor ExportPlaylist to use more idiomatic kotlin code

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions Bot added the size/medium PRs with less than 250 changed lines label Dec 31, 2025
Comment thread app/src/main/java/org/schabi/newpipe/local/playlist/ExportPlaylist.kt Outdated
@ghost ghost force-pushed the export_playlist_refactor branch from edacd69 to 49378d4 Compare January 1, 2026 08:20
@ghost ghost requested a review from theimpulson January 1, 2026 08:21
Copy link
Copy Markdown
Member

@theimpulson theimpulson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me other than a minor nitpick

Comment thread app/src/main/java/org/schabi/newpipe/local/playlist/PlayListShareMode.kt Outdated
@ghost ghost force-pushed the export_playlist_refactor branch from 49378d4 to 8379aa0 Compare January 1, 2026 13:05
@github-actions github-actions Bot added size/small PRs with less than 50 changed lines and removed size/medium PRs with less than 250 changed lines labels Jan 1, 2026
@theimpulson theimpulson enabled auto-merge January 1, 2026 13:35
@theimpulson theimpulson merged commit 1fb2b4a into TeamNewPipe:dev Jan 1, 2026
5 checks passed
@ghost ghost deleted the export_playlist_refactor branch January 7, 2026 18:53
@ShareASmile ShareASmile added the code quality Improvements to the codebase to improve the code quality label Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code quality Improvements to the codebase to improve the code quality size/small PRs with less than 50 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants