Conversion to kotlin of multiple files#12978
Merged
theimpulson merged 13 commits intodevfrom Jan 2, 2026
unknown repository
Merged
Conversion to kotlin of multiple files#12978theimpulson merged 13 commits intodevfrom unknown repository
theimpulson merged 13 commits intodevfrom
unknown repository
Conversation
ghost
changed the title
ghost
theimpulson
reviewed
Jan 1, 2026
theimpulson
reviewed
Jan 1, 2026
theimpulson
reviewed
Jan 1, 2026
theimpulson
reviewed
Jan 1, 2026
Also convert one class used by it into java record
Co-authored-by: Aayush Gupta <aayushgupta219@gmail.com>
added 5 commits
January 1, 2026 15:08
convert it to kotlin
theimpulson
approved these changes
Jan 2, 2026
Member
theimpulson
left a comment
theimpulson
left a comment
There was a problem hiding this comment.
Some code can be still improved but I will address that separately.
Member
|
Thank you! |
ShareASmile
added
the
code quality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence