Skip to content

Convert newpipe/util/image/ImageStrategy to kotlin#12967

Closed
ghost wants to merge 1 commit intorefactorfrom
unknown repository
Closed

Convert newpipe/util/image/ImageStrategy to kotlin#12967
ghost wants to merge 1 commit intorefactorfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Dec 28, 2025

What is it?

  • Codebase improvement (dev facing)

Description of the changes in your PR

  • Converted newpipe/util/image/ImageStrategy to kotlin
  • Thanks to kotlin removed some boilerplate for lambda declarations
  • Rewrote small portion of code in the beginning of choosePreferredImage from java stream api to kotlin collections api

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions Bot added the size/large PRs with less than 750 changed lines label Dec 28, 2025
@ghost ghost closed this Dec 31, 2025
@ghost ghost deleted the image_stategy_refactor branch January 7, 2026 18:53
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/large PRs with less than 750 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants