Skip to content

Misc small refactors (mostly replacing old switch syntax with new)#12963

Merged
theimpulson merged 1 commit intorefactorfrom
unknown repository
Jan 1, 2026
Merged

Misc small refactors (mostly replacing old switch syntax with new)#12963
theimpulson merged 1 commit intorefactorfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Dec 28, 2025 •
edited by ghost
Loading

What is it?

  • Bugfix (user facing)
  • Feature (user facing) ⚠️ Your PR must target the refactor branch
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Due diligence

@github-actions github-actions Bot added the size/medium PRs with less than 250 changed lines label Dec 28, 2025
theimpulson
theimpulson requested changes Jan 1, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@theimpulson theimpulson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the minor nitpick, rest looks good to me. Thank you!

Comment thread app/src/main/java/org/schabi/newpipe/local/playlist/PlayListShareMode.kt Outdated
@ghost ghost force-pushed the misc_refactor branch from f9aad6f to 127064d Compare January 1, 2026 08:28
@ghost ghost requested a review from theimpulson January 1, 2026 08:29
theimpulson
theimpulson approved these changes Jan 1, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@theimpulson theimpulson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@theimpulson theimpulson merged commit 2e8e203 into TeamNewPipe:refactor Jan 1, 2026
1 check passed
@ghost ghost deleted the misc_refactor branch January 1, 2026 09:00
@ShareASmile ShareASmile added the code quality Improvements to the codebase to improve the code quality label Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

code quality Improvements to the codebase to improve the code quality size/medium PRs with less than 250 changed lines

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@theimpulson @ShareASmile