Convert newpipe/util/text/TimestampLongPressClickableSpan.java to kotlin#12951
Conversation
Also convert one class used by it into java record
theimpulson
requested changes
Dec 28, 2025
Comment on lines
+43
to
+56
| when (relatedInfoService) { | ||
| ServiceList.YouTube -> | ||
| return relatedStreamUrl + "&t=" + timestampMatchDTO.seconds() | ||
| ServiceList.SoundCloud, ServiceList.MediaCCC -> | ||
| return relatedStreamUrl + "#t=" + timestampMatchDTO.seconds() | ||
| ServiceList.PeerTube -> | ||
| return relatedStreamUrl + "?start=" + timestampMatchDTO.seconds() | ||
| } | ||
|
|
||
| // Return timestamp text for other services | ||
| return descriptionText.subSequence( | ||
| timestampMatchDTO.timestampStart(), | ||
| timestampMatchDTO.timestampEnd() | ||
| ).toString() |
Member
There was a problem hiding this comment.
It should be possible to concat string and also lift the return statement out of the when block with an else logic.
Author
There was a problem hiding this comment.
I am dumb. Could you explain (about else)? And thanks for reviews
Comment on lines
+21
to
+22
| context, relatedStreamUrl, relatedInfoService, | ||
| timestampMatchDTO.seconds() |
Member
There was a problem hiding this comment.
Please put all on single line or separate if its over 100 char.
ghost
closed this
ghost
deleted the
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
refactorbranchDescription of the changes in your PR
newpipe/util/text/TimestampLongPressClickableSpan.javato kotlinAPK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence