External player: background service, MediaSession & controls#12761
Closed
osphvdhwj wants to merge 20 commits intoTeamNewPipe:devfrom
osphvdhwj:feature/mx-like-external-player
Closed
External player: background service, MediaSession & controls#12761osphvdhwj wants to merge 20 commits intoTeamNewPipe:devfrom osphvdhwj:feature/mx-like-external-player
osphvdhwj wants to merge 20 commits intoTeamNewPipe:devfrom
osphvdhwj:feature/mx-like-external-player
Conversation
… player UI and PiP support
…eed control, subtitle stub and manifest updates
… on hold, reverts on release. Fully respects main Tempo (no default).
…line at EOF for hold-nX gesture in VideoPlayerUi.java
Contributor
|
What's the goal of this PR? I don't really understand what you are trying to achive and why you are deleting a lot of code. Please explain what this PR is trying to achive. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds PlayerService, MediaSession, MediaStyle notification, speed control and subtitle placeholder. TODO: integrate extractor for YouTube streams, subtitle track support, casting, DRM and UX polish.
What's new in this PR:
Technical details:
PlayerService: LifecycleService with ExoPlayer and MediaSession integrationMediaNotificationManager: Handles notification creation and media controlsExternalPlayerActivity: Updated with service integration and new UI controlsTesting:
adb shell am start -a android.intent.action.VIEW -d "https://example.com/video.mp4" org.newpipe.externalplayer/.ExternalPlayerActivityNext steps: