Conversation
TobiGr
added
feature request
AudricV
added
the
template ignored
|
Need this feature! |
TobiGr
left a comment
TobiGr
left a comment
There was a problem hiding this comment.
Thank you for this PR. Things that need to be taken into account:
- Enabling the proxy in the settings should enable the proxy immediately or prompt the user to restart the app. Currently it looks like the proxy is enabled in the settings UI although it is actually not.
There was a problem hiding this comment.
it is a good idea to separate the strings so that strings.xml is not cluttered too much. However, I think this should be done for all strings at the same time in a separate PR. Please make this a section in string.xml for now.
There was a problem hiding this comment.
Where does this file come from?
|
Proxy for downloads is missing (see DownloadMission#openConnection) |
merges last main commits
github-actions
Bot
added
size/large
…_proxy_settings
…_proxy_settings # Conflicts: # app/src/main/java/org/schabi/newpipe/App.java # app/src/main/java/org/schabi/newpipe/util/image/PicassoHelper.java # app/src/main/res/values-ru/strings.xml # app/src/main/res/values/strings.xml
|
TobiGr and fokin33 thank you for your work, it is very important. |
|
@fokin33 From what I can see, this only works for YouTube and no other services |
It adds a proxy server to the default data source, so the proxy server is used for all services. |
6 participants
What is it?
Description of the changes in your PR
Add proxy settings
Before/After Screenshots/Screen Record
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence