Refactor codebase to use Instant instead of OffsetDateTime#12633
Open
Isira-Seneviratne wants to merge 10 commits intoTeamNewPipe:devfrom
Open
Refactor codebase to use Instant instead of OffsetDateTime#12633Isira-Seneviratne wants to merge 10 commits intoTeamNewPipe:devfrom
Isira-Seneviratne wants to merge 10 commits intoTeamNewPipe:devfrom
Conversation
Isira-Seneviratne
added
localisation/translation
Isira-Seneviratne
force-pushed
the
Refactor-extractor-date
branch
from
a901273 to
f4e9d00
Compare
Isira-Seneviratne
force-pushed
the
Refactor-extractor-date
branch
from
f4e9d00 to
4a9dcb0
Compare
This comment was marked as spam.
This comment was marked as spam.
Contributor
|
Refactoring changes looks good, I had a basic question about the changes in database entities. Do we need to add migration for those changes? @Isira-Seneviratne Could you please confirm that |
Member
Author
No, because the underlying data type stored in the database hasn't changed. |
# Conflicts: # app/build.gradle
Isira-Seneviratne
force-pushed
the
Refactor-extractor-date
branch
from
bda1959 to
76204ef
Compare
Isira-Seneviratne
force-pushed
the
Refactor-extractor-date
branch
from
76204ef to
550fc2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Instantinstead ofOffsetDateTime, to accommodate some extractor changes.Relies on the following changes
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence